[Fix] - JPQL 관련 alias ambiguous 예외 발생 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 31 files 31 suites 8s ⏱️ Results for commit 216a756. |
Libienz
approved these changes
Aug 20, 2024
Comment on lines
+20
to
+30
| @Override | ||
| public void deleteAllByTravelogue(Travelogue travelogue) { | ||
| jpaQueryFactory.update(traveloguePhoto) | ||
| .set(traveloguePhoto.deletedAt, LocalDateTime.now()) | ||
| .where(traveloguePhoto.traveloguePlace.travelogueDay.eq( | ||
| JPAExpressions.selectFrom(travelogueDay) | ||
| .leftJoin(QTravelogue.travelogue) | ||
| .on(QTravelogue.travelogue.eq(travelogue)) | ||
| )) | ||
| .execute(); | ||
| } |
There was a problem hiding this comment.
서브 쿼리 사용된 부분이군요.
서브 쿼리들은 메타 정보를 이용하지 않기 때문에 DB의 최적화를 받지 못하죠.
흔히들 얘기하는 서브쿼리의 성능 측면의 단점입니다.
그래서 조인이 훨씬 우아한 방법이라고 생각합니다! Join은 웬만한 데이터베이스 벤더에서 모두 최적화를 지원하니까요 👍🏻
다만..! 성능 최적화는 이후에 얘기하는 걸로 하시고 저희 도메인 설계도 바뀌게 될 것 같으니 코멘트만 남겨놓습니다 🙇🏻♂️
There was a problem hiding this comment.
사실, update와 join을 어떻게 조합해야할지 감이 잡히지 않아서 서브 쿼리를 활용했습니다.
도메인 변경 이후, QueryDSL 코드를 전반적으로 재검토 해야할 것 같아요.
There was a problem hiding this comment.
이전에 select 절에 사용된 서브쿼리는 DBA 소환술이라고 소개받은 적이 있습니다.
where절은 어느 정도 참을 수 있는 것 같기는 하지만 개인의 선호라 코멘트 드려보았습니다
hangillee
added a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* fix: 중복되는 table alias 변경 * fix: 예외 발생 중인 JPQL을 대체하는 QueryDSL 구현 * fix: 여행기 삭제 및 수정 기능 쿼리 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용