[Feature] - JPA Auditing을 위한 BaseEntity 생성 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nak-honest
requested changes
Jul 17, 2024
Comment on lines
14
to
15
|
|
||
| } |
There was a problem hiding this comment.
클래스 마지막에 개행 빼주시면 감사하겠습니다!!
(리건씌가 넣으신 건 아니긴 한데,,, 빼주시면 감사하겠습니다 ㅎㅎ)
Comment on lines
14
to
21
| public class BaseEntity { | ||
|
|
||
| @CreatedDate | ||
| private LocalDateTime createdAt; | ||
|
|
||
| @LastModifiedDate | ||
| private LocalDateTime modifiedAt; | ||
| } |
There was a problem hiding this comment.
인스턴스화가 불가능하도록 abstract class로 정의해도 좋을 것 같아요!
Libienz
requested changes
Jul 17, 2024
Comment on lines
11
to
14
| @Getter | ||
| @MappedSuperclass | ||
| @EntityListeners(AuditingEntityListener.class) | ||
| public class BaseEntity { |
There was a problem hiding this comment.
낙낙한테 들었는데 저도 BaseEntity는 Abstract 이 좋을 것 같습니다
불필요한 인스턴스화 막을 수 있을 것 같아요
방어적인 코드로의 개선, 리건은 어떻게 생각하시나유?
eunjungL
requested changes
Jul 17, 2024
| @Getter | ||
| @MappedSuperclass | ||
| @EntityListeners(AuditingEntityListener.class) | ||
| public class BaseEntity { |
There was a problem hiding this comment.
soft delete 도입하기로 했슴다
deletedAt 추가 부탁드려용
nak-honest
approved these changes
Jul 17, 2024
eunjungL
pushed a commit
that referenced
this pull request
Jul 30, 2024
* refactor: 패키지 구조 변경 * feat: JPA Auditing을 위한 BaseEntity 추가 * refactor: BaseEntity 추상 클래스화 및 코드 컨벤션 준수
hangillee
added a commit
to hangillee/2024-touroot
that referenced
this pull request
Aug 20, 2024
* refactor: 패키지 구조 변경 * feat: JPA Auditing을 위한 BaseEntity 추가 * refactor: BaseEntity 추상 클래스화 및 코드 컨벤션 준수
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용