[또링] 체스 1주차 미션 제출합니다. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-hyungu
requested changes
Apr 4, 2020
src/main/java/view/OutputView.java
Outdated
|
|
||
| public static void printChessBoard(BoardGame board) { | ||
| List<Rank> ranks = board.getBoard().getRanks(); | ||
| for (int rankIndex = ranks.size() - 1; rankIndex >= 0; rankIndex--) { |
There was a problem hiding this comment.
board에서 랭크 반환할 때 역순서로 만들어서 반환해도 되겠네요
There was a problem hiding this comment.
🎤 좋은 지적 감사합니다! 한 가지 궁금한 게 있습니다.
board의 역순이 필요한 경우는 출력하는 경우밖에 없는데, 이런 경우에도 view를 위해 도메인에서 역순서로 된 객체를 반환하는 메서드를 만드는 것이 더 좋을까요?
There was a problem hiding this comment.
view 전용 기능을 추가한다기 보다 Rank 리스트를 역순으로 반환하는 기능 추가라고 생각하면 되겠죠
kang-hyungu
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 리뷰를 받게 된 또링이라고 합니다. 아직 모르는 부분이 많은데, 많이 지적해주시면 열심히 고쳐보겠습니다!😁 잘 부탁드립니다.