[1, 2단계 - 체스] 페드로(류형욱) 미션 제출합니다. #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
Co-authored-by: Hyunguk Ryu <hw0603@naver.com>
…고 iterate() 인자로 종료조건 명시
- 타입이 팀 정보를 각각 가지기 -> 팀이 자신의 팀에 포함된 타입들을 가지기
|
커밋메세지를 정말 꼼꼼하게 작성해주셨네요 고생많으셨습니다. 힘들진않으셨나요? |
JunHoPark93
approved these changes
Mar 24, 2024
| import java.util.Map; | ||
|
|
||
| public record Position(File file, Rank rank) { | ||
| private static final Map<String, Position> CACHE = new HashMap<>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 제이, 체스 미션 리뷰이 페드로입니다!
이번 미션은 설계하는데 시간이 꽤 걸린 탓에 시간이 많이 남지 않아 만족할 만한 수준으로 리팩토링하지는 못한 것 같네요😅
특히
PawnMoveStrategy쪽에 중복 코드가 많이 존재하는데, 차차 리팩토링하도록 하겠습니다.리뷰 잘 부탁드립니다!