[로또 - 웹, DB] 효오 미션 제출합니다. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning lotto numbers method
…on classes and interfaces
…al lotto, autto lotto
…d change WinningLotto Instance
pobiconan
requested changes
Jun 16, 2019
| import java.util.Map; | ||
|
|
||
| public class WebLottoController { | ||
| public static String main(Request request, Response response) throws SQLException { |
There was a problem hiding this comment.
메소드 이름이 main()은 적합해 보이지 않음.
| import java.util.Map; | ||
|
|
||
| public class WebLottoController { | ||
| public static String main(Request request, Response response) throws SQLException { |
There was a problem hiding this comment.
Controller의 모든 메소드 인자가 같은데 인터페이스로 구현해 보는 것은 어떨까?
| private static final int TOTAL_MONEY_COLUMN = 7; | ||
| private static final int YEILD_COLUMN = 8; | ||
|
|
||
| public static void addResult(RankResult rank, Money money) throws SQLException { |
There was a problem hiding this comment.
DAO 구현부를 보면 많은 중복이 보인다.
중복을 제거할 수 있는 방법을 찾아본다.
pobiconan
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.