[호프-도리] 계산기 미션 제출합니다. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefer2
reviewed
Feb 15, 2022
| } | ||
|
|
||
| const isStartZero = (number, newNumber) => { | ||
| return number.length === 0 && newNumber === '0' |
There was a problem hiding this comment.
return만 할 경우 const validateNumber = (number) => typeof number === 'number'로 수정 가능
| TOTAL:'#total' | ||
| } | ||
|
|
||
| const ERROR = { |
| if(!validateNumberLength(this.right)) return alert(ERROR.DIGIT_LENGTH); | ||
| if (isStartZero(this.left, number)) return alert(ERROR.START_ZERO); | ||
| this.right += number; | ||
| total.innerHTML+= number; |
| import './commands' | ||
|
|
||
| // Alternatively you can use CommonJS syntax: | ||
| // require('./commands') |
There was a problem hiding this comment.
불필요한 주석은 삭제하고, 불필요한 파일들은 삭제 또는 .gitignore를 통해 올리지 않기
| operationClick("="); | ||
| checkAlertMessage(ERROR.WRONG_EXPRESSION); | ||
| }); | ||
| }) |
| '/' : (left,right) => {if (isValidateInput(left, right)) return Math.floor(left / right);} | ||
| } | ||
|
|
||
| export { validateNumberLength, isStartZero, calculate} |
| cy.on('window:alert', (str) => { | ||
| expect(str).to.equal(message) | ||
| }) | ||
| } |
There was a problem hiding this comment.
오류가 alert인지 테스트코드에서는 알 수 없기 때문에 stub을 사용하기
|
|
||
| const SELECTOR = { | ||
| CALCULATOR: '.calculator', | ||
| TOTAL:'#total' |
| if (eventClassName === CLASS.OPERATION) { | ||
| return this.operationHandler(event.target.innerHTML); | ||
| } | ||
| }) |
| digitHandler(number) { | ||
| const total = document.querySelector(SELECTOR.TOTAL); | ||
| if (!this.operator) { | ||
| console.log(this.operator, this.left) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
페어프로그래밍이 처음이라서, 시간이 조금 오래걸리기도 했지만, 혼자 할 때보다 두배는 더 빠르게 에러를 해결하고 좋은 코드에 대한 고민을 할 수 있었던 시간이었습니다 :)
다만 아쉬운점은 테스트코드를 추후에 작성해서 비효율적인 수동 테스트를 거쳐야했는데요, 다음 미션에서는 꼭 테스트 먼저 작성하는 TDD를 도입해보고싶습니다.