Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1단계 - 영화 목록 불러오기] 윤생(이윤성) 미션 제출합니다. #6

Merged
merged 52 commits into from
Mar 25, 2023
Merged

[1단계 - 영화 목록 불러오기] 윤생(이윤성) 미션 제출합니다. #6

merged 52 commits into from
Mar 25, 2023

Commits on Mar 14, 2023

  1. docs: 기능 요구 사항 작성 

    Co-authored-by: 2yunseong <2yunseong@users.noreply.github.com>
    @ksone02 @2yunseong
    ksone02 and 2yunseong committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e2865f8 View commit details
    Browse the repository at this point in the history

  2. feat: 컴포넌트 분리 구현

    @ksone02
    ksone02 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7bc8633 View commit details
    Browse the repository at this point in the history

  3. feat: 이미지 밑 스타일 임포트

    @ksone02
    ksone02 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    294448a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. feat: 인기 영화 데이터 fetch 후 render 구현

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cd2da9f View commit details
    Browse the repository at this point in the history

  2. feat: 인기 영화 더보기 기능 구현

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    04cade7 View commit details
    Browse the repository at this point in the history

  3. feat: 영화 검색 기능 구현

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    b55d92f View commit details
    Browse the repository at this point in the history

  4. feat: API 키 ignore

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    354c7c8 View commit details
    Browse the repository at this point in the history

  5. refactor: 컴포넌트 폴더 분리

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    1d3bb2f View commit details
    Browse the repository at this point in the history

  6. feat: 영화 API 페이지 상태관리

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    0c225ea View commit details
    Browse the repository at this point in the history

  7. refactor: 중복되는 api 호출 로직 모듈화

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    5cd6447 View commit details
    Browse the repository at this point in the history

  8. refactor: 중복되는 렌더링 로직 모듈화

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f7d9a32 View commit details
    Browse the repository at this point in the history

  9. refactor: initialRender 메서드 변경

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    99e1c57 View commit details
    Browse the repository at this point in the history

  10. feat: 에러에 따른 렌더링 구현

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    9cfe83e View commit details
    Browse the repository at this point in the history

  11. feat: 에러 컴포넌트 구현

    @ksone02
    ksone02 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    9ce56fd View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. test: 영화 리뷰 미션 e2e 테스트 작성 

    Co-authored-by: 2yunseong <2yunseong@users.noreply.github.com>
    @ksone02 @2yunseong
    ksone02 and 2yunseong committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    27d2315 View commit details
    Browse the repository at this point in the history

  2. refactor: Movie List Deprecated 된 코드 제거

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    4c0081f View commit details
    Browse the repository at this point in the history

  3. refactor: console.log 제거

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    4bc7246 View commit details
    Browse the repository at this point in the history

  4. refactor: MoreButton 컴포넌트 코드 가독성 개선

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cef4beb View commit details
    Browse the repository at this point in the history

  5. refactor: 코드 상수화

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    2847cc7 View commit details
    Browse the repository at this point in the history

  6. refactor: event 위임 로직 if문 switch문으로 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    52b82d7 View commit details
    Browse the repository at this point in the history

  7. refactor: Movie list HTML 구조 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7671371 View commit details
    Browse the repository at this point in the history

  8. refactor: header HTML 구조 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cf4c7c0 View commit details
    Browse the repository at this point in the history

  9. refactor: Movie List Title HTML 구조 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    b416e43 View commit details
    Browse the repository at this point in the history

  10. refactor: App 내의 불필요한 document 선언 제거

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    042fdf2 View commit details
    Browse the repository at this point in the history

  11. refactor: Skeleton 불필요한 li태그 제거

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5472125 View commit details
    Browse the repository at this point in the history

  12. refactor: App 내부 변수명 통일

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f92c4ee View commit details
    Browse the repository at this point in the history

  13. refactor: App 불필요한 필드 제거

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    188c7a8 View commit details
    Browse the repository at this point in the history

  14. refactor: List Method 네이밍 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    8daad3f View commit details
    Browse the repository at this point in the history

  15. refactor: API 처리 로직 구조 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    051e31a View commit details
    Browse the repository at this point in the history

  16. feat: 로고 클릭시 input value 초기화

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    a76098d View commit details
    Browse the repository at this point in the history

  17. refactor: url 생성 책임 분리

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e0adc38 View commit details
    Browse the repository at this point in the history

  18. refactor: App 더보기 버튼 액션 변경 메소드 분리

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0f334d1 View commit details
    Browse the repository at this point in the history

  19. refactor: App 컴포넌트 코드 가독성 개선

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    4e865a7 View commit details
    Browse the repository at this point in the history

  20. refactor: TITLE 상수화 객체 타입 단언

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    c90298e View commit details
    Browse the repository at this point in the history

  21. refactor: 컴포넌트 전체적 가독성 개선

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    5ba2e9b View commit details
    Browse the repository at this point in the history

  22. refactor: constants 디렉토리 변경

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    d977044 View commit details
    Browse the repository at this point in the history

  23. docs: README.md 작성

    @ksone02
    ksone02 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    37dec5a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. refactor: 사용되지 않는 매개변수 선언 제거

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2b4d446 View commit details
    Browse the repository at this point in the history

  2. fix: html 마크업 수정

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c320fcd View commit details
    Browse the repository at this point in the history

  3. refactor: cypress 불필요한 파일 제거

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    15c8f36 View commit details
    Browse the repository at this point in the history

  4. refactor: 웹 접근성 개선

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6836501 View commit details
    Browse the repository at this point in the history

  5. refactor: 마크업 구조 변경에 따른 테스트 수정

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    81241e9 View commit details
    Browse the repository at this point in the history

  6. chore: 기술에 대한 정보를 제공하는 주석 추가

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f3d200d View commit details
    Browse the repository at this point in the history

  7. refactor: early return / 모호한 네이밍 수정

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    749e8f2 View commit details
    Browse the repository at this point in the history

  8. test: 검색창 공백 입력 시/ 입력이 비어있을 시 테스트 추가

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    fe64426 View commit details
    Browse the repository at this point in the history

  9. fix: 공백을 입력 시 검색을 하는 오류 수정

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7c81f7e View commit details
    Browse the repository at this point in the history

  10. test: 테스트 명 수정

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    298e925 View commit details
    Browse the repository at this point in the history

  11. feat: 오류 메세지 페이지에 CTA 버튼 추가

    @2yunseong
    2yunseong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4e6de67 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. refactor: fetch 재사용화를 위한 책임 분리

    @2yunseong
    2yunseong committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    eaf2fbc View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. fix: totalPage 상태값 갱신하지 않은 오류 해결

    @2yunseong
    2yunseong committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6e07659 View commit details
    Browse the repository at this point in the history

  2. test: 엘리먼트 선택자 변경

    @2yunseong
    2yunseong committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2079624 View commit details
    Browse the repository at this point in the history

  3. refactor: custom component 네이밍 변경

    @2yunseong
    2yunseong committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    7563963 View commit details
    Browse the repository at this point in the history