[JDBC 라이브러리] 효오 미션 제출합니다. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
young891221
suggested changes
Oct 17, 2019
| this.dataSource = dataSource; | ||
| } | ||
|
|
||
| public T queryForObject(String sql, PreparedStatementSetter pstmtSetter, RowMapper<T> rowMapper) throws SQLException { |
There was a problem hiding this comment.
반환값이 Optional이면 외부에서 사용하기 한결 더 편리해 보입니다.
| return query(sql, pstmtSetter, rowMapper).get(0); | ||
| } | ||
|
|
||
| public List<T> query(String sql, PreparedStatementSetter pstmtSetter, RowMapper<T> rowMapper) throws SQLException { |
There was a problem hiding this comment.
query(), update() 메서드에 중복 코드가 존재합니다. 인터페이스를 구현하여 할당 시키는 부분만 다른데요. 중복코드 제거해서 하나로 통일할 수 잇지 않을까요?ㅎㅎ
| import java.sql.SQLException; | ||
|
|
||
| @FunctionalInterface | ||
| public interface PreparedStatementSetter { |
| import java.sql.SQLException; | ||
|
|
||
| @FunctionalInterface | ||
| public interface RowMapper<T> { |
- T -> Optional<T>
young891221
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 영재님
이번에 jdbc 미션을 진행하면서 그 동안 자바 기능을 많이 활용하지 못했다고 느꼈고, 자바에 대해 다시 학습할 수 있는 기회였습니다.
많은 지적 부탁드리겠습니다!
(try-with-resources 구문에 대한 중복은 어떻게 제거해야 할지 모르겠네요...)