Skip to content

Commit

Permalink
docs: update guide for reviewer
Browse files Browse the repository at this point in the history
  • Loading branch information
wmakerjun authored Sep 12, 2023
1 parent 9ae659e commit 50f1edd
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,21 @@
## πŸ”— μ°Έκ³  링크 (선택 사항)

(μœ μš©ν–ˆλ˜ μ°Έκ³  μžλ£Œλ‚˜ λ ˆνΌλŸ°μŠ€κ°€ μžˆλ‹€λ©΄ 링크 첨뢀)

---

# πŸ“ 리뷰어λ₯Ό μœ„ν•œ κ°€μ΄λ“œλΌμΈ

이번 λ―Έμ…˜μ˜ 핡심 κ²½ν—˜μ€ 'CSS'λ₯Ό 더 잘 ν™œμš©ν•˜λŠ” κ²ƒμž…λ‹ˆλ‹€. κ·Έλž˜μ„œ μ½”λ“œ 리뷰 진행 μ‹œ, Reactλ₯Ό μ΄μš©ν•œ κΈ°λŠ₯적인 λΆ€λΆ„λ³΄λ‹€λŠ” μ•„λž˜μ™€ 같은 κ°€μ΄λ“œλΌμΈμ„ 'μ°Έκ³ 'ν•˜μ—¬, CSS의 κ°œμ„ μ„ κ³ λ €ν•œ ν”Όλ“œλ°±μ„ λ‚¨κ²¨μ£Όμ„Έμš”.

### λ ˆμ΄μ•„μ›ƒ μ»΄ν¬λ„ŒνŠΈκ°€ μ—¬λŸ¬ ν™˜κ²½μ—μ„œλ„ 잘 λ³΄μ΄λŠ”μ§€ 확인해 μ£Όμ„Έμš”
- [ ] λ°˜μ‘ν˜•: λ ˆμ΄μ•„μ›ƒμ΄ λ‹€μ–‘ν•œ ν™”λ©΄ 크기에 μ μ‘ν•˜λŠ”μ§€ 확인해 μ£Όμ„Έμš”.
- [ ] 크둜슀 λΈŒλΌμš°μ§•: μ—¬λŸ¬ λΈŒλΌμš°μ €(크둬, μ‚¬νŒŒλ¦¬, 엣지 λ“±)μ—μ„œ λ™μž‘ν•˜λŠ”μ§€ 확인해 μ£Όμ„Έμš”.

### λ ˆμ΄μ•„μ›ƒ μ»΄ν¬λ„ŒνŠΈλ₯Ό μ‚¬μš©ν•˜λŠ” μ‚¬μš©μžλ‘œμ„œ, 잘 μ΄ν•΄ν•˜κ³  ν™œμš©ν•  수 μžˆμ—ˆλŠ”μ§€ ν”Όλ“œλ°±ν•΄ μ£Όμ„Έμš”
- [ ] 가독성: READMEλ‚˜ μ‚¬μš©λ²•μ„ 보고, μ €μžμ˜ μ˜λ„κ°€ 잘 μ΄ν•΄λ˜λŠ”μ§€ λ…μžμ˜ μž…μž₯μ—μ„œ 확인해 μ£Όμ„Έμš”.
- [ ] μ‚¬μš©μ„±: λ ˆμ΄μ•„μ›ƒ μ»΄ν¬λ„ŒνŠΈλ₯Ό μ‚¬μš©ν•˜λŠ” μž…μž₯μ—μ„œ μ‰½κ²Œ μ‚¬μš©ν•  수 μžˆμ—ˆλŠ”μ§€ 확인해 μ£Όμ„Έμš”.

### μŠ€νƒ€μΌ μ½”λ“œκ°€ 넀이밍, μž¬μ‚¬μš©μ„± 등을 κ³ λ €ν•΄ 잘 μž‘μ„±λ˜μ–΄ μžˆλŠ”μ§€ 확인해 μ£Όμ„Έμš”
- [ ] 의미둠적 넀이밍: ν•΄λ‹Ή CSS ν΄λž˜μŠ€λ‚˜ ID의 이름이 의미둠적으둜 μ μ ˆν•œμ§€ 확인해 μ£Όμ„Έμš”.
- [ ] μž¬μ‚¬μš©μ„±: μ€‘λ³΅λ˜κ±°λ‚˜ λΆˆν•„μš”ν•œ μŠ€νƒ€μΌ κ·œμΉ™μ΄ μžˆλŠ”μ§€ μ‚΄νŽ΄λ³΄μ„Έμš”.

0 comments on commit 50f1edd

Please sign in to comment.