-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[점심 뭐 먹지 미션 Step 2] 윤생(이윤성) 미션 제출합니다. #64
Merged
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c362b95
refactor(Drawer): 함수형 컴포넌트로 변경
2yunseong 01ac77c
refactor(Header): 함수형 컴포넌트로 변경
2yunseong b7f2109
refactor(Select): 함수형 컴포넌트로 변경
2yunseong e8a33ce
refactor(MainHeader): 함수형 컴포넌트로 변경
2yunseong 3ad22ae
refactor(RestaurantDetailDrawer): 함수형 컴포넌트로 변경
2yunseong 310aee7
refactor(RestaurantItem): 함수형 컴포넌트로 변경
2yunseong 14bd03b
refactor: 메서드 분리
2yunseong 136ee31
refactor: type 명 구체화
2yunseong 86a387b
refactor(RestaurantList): 함수형 컴포넌트로 변경
2yunseong 0aeafd1
refactor(SelectContainer): 함수형 컴포넌트로 변경
2yunseong 53cbdda
refactor(App): 함수형 컴포넌트로 변경
2yunseong 18be4e1
fix: 페이지 title 수정
2yunseong a4a480f
refactor: 로컬스토리지 로직 Custom Hook 으로 변경
2yunseong 1a170e6
chore: typescript config 설정
2yunseong d753b1b
style: 코드 포맷팅
2yunseong 6dae5e2
refactor: type import 명시
2yunseong 597a866
refactor: 의미에 맞는 변수명 변경
2yunseong 02bb074
chore: trivial
2yunseong fc22a75
refactor: 디렉터리 네이밍 변경
2yunseong f4eb604
refactor: React.FC 선언 제거
2yunseong 139223d
style: 코드 포맷팅
2yunseong 6c20b21
feat: 필터링을 해주는 로직 Hook으로 분리
2yunseong af8939e
refactor: type 분리
2yunseong aa8a891
refactor: 프로퍼티 네이밍 변경
2yunseong 5429324
feat: 웹 접근성 개선
2yunseong ab48c82
feat: default로 전달하는 함수 네이밍
2yunseong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,12 @@ | ||
import React from 'react'; | ||
import Header from './common/Header.tsx'; | ||
import Header from './components/Header.tsx'; | ||
|
||
class MainHeader extends React.Component { | ||
render() { | ||
return ( | ||
<Header> | ||
<h1 className="gnb__title text-title">점심 뭐 먹지</h1> | ||
</Header> | ||
); | ||
} | ||
} | ||
const MainHeader = () => { | ||
return ( | ||
<Header> | ||
<h1 className="gnb__title text-title">점심 뭐 먹지</h1> | ||
</Header> | ||
); | ||
}; | ||
|
||
export default MainHeader; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분과
const [isOpenDrawer, setIsOpenDrawer] = useState<boolean>(false);
해당 상태는 App 에서가 아닌 RestaurantDetailDrawer 안에서 정의해도 되지않을까요? 최대한 App은 가벼운게 좋습니당!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drawer를 열고 닫는 부분이 같은 계층에 있는 RestraurantItem과 RestaurantDetailDrawer 둘다에 있어서 다음과 같이 주었습니다!
state 끌어올리기를 참고했어요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 RestraurantItem, RestaurantDetailDrawer 둘다 필요하군요! 이해했습니다