Fix copy paste #1193
Merged
Fix copy paste #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
May 24, 2019
There was a problem hiding this comment.
This looks good – tests pass and the code is simple enough.
Tested:
✅ Pastes into Messages as Plain Text.
✅ Pastes into Notes as semi-rich text – headings, bold, italic, underline etc work. Lists don't have bullets or numbers.
✅ Pastes into WP in exactly the same way it was copied.
Works for me, so merging.
koke
reviewed
May 27, 2019
| @@ -555,7 +555,11 @@ open class TextView: UITextView { | |||
| // MARK: - Pasteboard Helpers | |||
|
|
|||
| internal func storeInPasteboard(encoded data: Data, pasteboard: UIPasteboard = UIPasteboard.general) { | |||
| pasteboard.setData(data, forPasteboardType: NSAttributedString.pastesboardUTI) | |||
| if pasteboard.numberOfItems > 0 { | |||
| pasteboard.items[0][NSAttributedString.pastesboardUTI] = data; | |||
There was a problem hiding this comment.
I don't understand why we're doing this one. Why not use setItems(_:options:) in both cases?
There was a problem hiding this comment.
I tried that, but setItems will reset everything, so unless you first copy what you already have there and add the extra UTI to it.
1 task
|
setItems was overwritting the values already there, unless you copy them
first... and then apply again.
…On Mon, 27 May 2019 at 08:35, Jorge Bernal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Aztec/Classes/TextKit/TextView.swift
<#1193 (comment)>
:
> @@ -555,7 +555,11 @@ open class TextView: UITextView {
// MARK: - Pasteboard Helpers
internal func storeInPasteboard(encoded data: Data, pasteboard: UIPasteboard = UIPasteboard.general) {
- pasteboard.setData(data, forPasteboardType: NSAttributedString.pastesboardUTI)
+ if pasteboard.numberOfItems > 0 {
+ pasteboard.items[0][NSAttributedString.pastesboardUTI] = data;
I don't understand why we're doing this one. Why not use
setItems(_:options:)
<https://developer.apple.com/documentation/uikit/uipasteboard/1829417-setitems>
in both cases?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1193?email_source=notifications&email_token=AAE7CUNILHIEQPDTAZEMOVDPXOFLJA5CNFSM4HPREMDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZXKYOQ#pullrequestreview-242134074>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE7CUJX4X53RGRVFXZLYY3PXOFLJANCNFSM4HPREMDA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This PR brings the fix for copy paste to develop.
To test: