Remove failed uploads is not working in block editor

[mkevins]

Description

I encountered an issue with media blocks (video and image) after a failed upload. When I have a failed upload in a post, I am unable to "UPDATE" the post after that point, and "REMOVE FAILED UPLOADS" does not seem to work. If I "RETRY" the upload successfully, or "REMOVE" the media from the "Please tap for options" dialog, "UPDATE" resumes working normally. However, if I remove the block via the trash icon, I can no longer "UPDATE" the post, and I cannot "REMOVE" the failed uploads. This results in a condition where my local changes can never be uploaded.

Steps to reproduce the behavior

1. Open a post (with the block editor).
2. Add an image block.
3. Put device in ✈️ airplane mode.
4. Select Add Image -> Choose from device.
5. Select an image (observe that the upload fails with "Failed to insert media. ...").

6. Tap the 🗑️ trash icon to remove the block.
7. Turn off ✈️ airplane mode.
8. Tap "UPDATE" to upload the changes to the server.

Expected behavior

The changes should save to the server.

Actual behavior

Saving the changes is prevented with the following dialog: "Some media uploads have failed. You can't save or publish your post in this state. Would you like to remove all failed media?" Options: { "CANCEL", "REMOVE FAILED UPLOADS"}.

Selecting "REMOVE FAILED UPLOADS" does not appear to have any effect.

Screencast

Originally encountered while testing video block:

Tested on Pixel 2 Emulator, Android 27, WPAndroid 654bf6d

Additional information

The GutenbergEditorFragment has a method hasFailedMediaUploads which returns true if the post still has mFailedMediaIds. This prevents the post from updating, and results in showRemoveFailedUploadsDialog being called instead. The removeAllFailedMediaUploads method, however, does not remove anything. In examining the code, I noticed that the isUploadingMedia method of the same class always returns false. This seems to suggest that the responsibility of tracking upload progress is not intended to be handled by this class. @hypest wdyt?

[hypest]

This seems to suggest that the responsibility of tracking upload progress is not intended to be handled by this class.

Allow me to summon @mzorz on this one as I'm sure Mario will have good context to add on this.

[stale]

This issue has been marked as stale because:

• It has been inactive for the past year.
• It isn't in a project or a milestone.
• It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

[mzorz]

hi @mkevins Is this issue still valid? let me know :D thanks!

[mkevins]

😄 This appears to no longer be an issue. I retested on 14.9 via the steps described (using "save" instead of "update"), on both a new post as well as an already existing post, and the post can be saved after removal of the block containing failed media. Note: the media is still queued for upload, and uploads when the post is saved, but this does not prevent the post from being saved, which was the original cause for the issue.