Gutenberg mobile release v1.6.0

[hypest]

This PR updates the gutenberg-mobile reference to point to the latest release, v1.6.0.

The reference is currently pointing to the release/1.6.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: wordpress-mobile/gutenberg-mobile#1036.

To test:
The block editor should work as normal.

Update release notes:

• If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

[hypest]

We found some issues with the video and the quote blocks so, we've decided over Slack to hold back the release, put the video, quote blocks behind the __DEV__ flag to only have them on debug builds, and then do the code freeze.

Notes:

1. @daniloercoli found an issue with the video block crashing the app with Error while updating property 'backgroundColor' of a view managed by: RCTVideo. Ticket pending.
2. Put the video, quotes block behind the __DEV__ flag
3. The video is always muted while in the editor (preview)

Similar notes on the iOS PR: wordpress-mobile/WordPress-iOS#11786 (comment)

[daniloercoli]

Here are the links to the issues I found while testing videos:

• [GB-mobile v1.6] Crash of the editor when the media file upload finishes on the Video block #9943 (Crash of the editor only)
• [GB-mobile + Video block + Android 7.1] Crash when playing a video and rotate the device #9946 (Crash of the whole app)

[mkevins]

While smoke testing this I encountered an issue with the video block after a failed upload. When I had a failed upload in a post, then left the post, and then reopened it to edit it, the video block is not shown properly. I am unable to "UPDATE" the post after that point, and "REMOVE FAILED UPLOADS" does not seem to work.

Steps to reproduce:

1. Open a post (with the block editor).
2. Add a video block.
3. Select Add Video -> Choose from device
4. Put device in ✈️ airplane mode.
5. Select a video (observe that the upload fails with "Failed to insert media. ...").
6. Turn off ✈️ airplane mode.
7. Leave the post (observe that the post list shows: "Unable to upload this posts's media").
8. Re-open the post (observe that the video block is shown as a horizontal line).
9. Select the "empty" video block.
10. Tap the 🗑️ trash icon to remove the block.
11. Tap "UPDATE" to upload the changes to the server.

Expected behavior:
The changes should save to the server.

Actual behavior:
Saving the changes is prevented with the following dialog: "Some media uploads have failed. You can't save or publish your post in this state. Would you like to remove all failed media?" Options: { "CANCEL", "REMOVE FAILED UPLOADS"}.

Selecting "REMOVE FAILED UPLOADS" does not appear to have any effect.

Screencast:

This issue is tracked here: #9953

[daniloercoli]

LGTM!
We've found a bug on the title reported here wordpress-mobile/gutenberg-mobile#1053, but agreed on slack to merge this anyway, and check for .1 release on Monday.

[peril-wordpress-mobile]

	Fails
🚫	Danger failed to run /app/danger-0.c4not1gnb4j.ts,/app/danger-0.i1tbui8o46l.ts.

Error Error

ENOENT: no such file or directory, open '/app/danger-0.i1tbui8o46l.ts'

Error: ENOENT: no such file or directory, open '/app/danger-0.i1tbui8o46l.ts'
    at Object.openSync (fs.js:439:3)
    at Object.readFileSync (fs.js:344:35)
    at Object.<anonymous> (/app/node_modules/danger/distribution/runner/runners/vm2.js:106:87)
    at step (/app/node_modules/danger/distribution/runner/runners/vm2.js:43:23)
    at Object.next (/app/node_modules/danger/distribution/runner/runners/vm2.js:24:53)
    at fulfilled (/app/node_modules/danger/distribution/runner/runners/vm2.js:15:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

import {warn, fail, danger} from "danger";

export default async () => {

    if (danger.github == null || danger.github.pr == null) {
        fail("Not running on a Github PR.");
        return;
    }

    console.log(Object.keys(danger.github));

    const githubLabels = danger.github.issue.labels;

    // A PR should have at least one label
    if (githubLabels.length == 0) {
        warn("PR is missing at least one label.");
    }

    // A PR shouldn't be merged with the 'DO NOT MERGE' label
    const doNotMerge = githubLabels.some(label => label.name.includes("DO NOT MERGE"));
    if (doNotMerge) {
        warn("This PR is tagged with 'DO NOT MERGE'.");
    }

    // Warn if the PR doesn't have a milestone
    const issue = await danger.github.api.issues.get(danger.github.thisPR);
    if (issue.data.milestone == null) {
        warn("PR is not assigned to a milestone.");
    }

    // Warn when there is a big PR
    if (danger.github.pr.additions + danger.github.pr.deletions > 500) {
        warn("PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.");
    }

};

---

Generated by 🚫 dangerJS