Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg to 1.6.0 #11786

Merged
merged 7 commits into from
May 31, 2019
Merged

Update Gutenberg to 1.6.0 #11786

merged 7 commits into from
May 31, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented May 27, 2019

This PR updates the gutenberg-mobile reference to point to the latest release, v1.6.0.

The reference is currently pointing to the release/1.6.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: wordpress-mobile/gutenberg-mobile#1036.

To test:
The block editor should work as normal.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added the Gutenberg Editing and display of Gutenberg blocks. label May 27, 2019
@hypest hypest added this to the 12.6 milestone May 27, 2019
@hypest hypest requested a review from koke May 27, 2019 12:08
@hypest
Copy link
Contributor Author

hypest commented May 27, 2019

FYI, produced the changes in 61a503c by manually editing the Podfile to point to the gutenberg-mobile commit hash and then ran pod update in the command line.

@hypest
Copy link
Contributor Author

hypest commented May 27, 2019

We found some issues with the video and the quote blocks so, we've decided over Slack to hold back the release, put the video, quote blocks behind the __DEV__ flag to only have them on debug builds, and then do the code freeze.

@koke
Copy link
Member

koke commented May 27, 2019

Found some issues that I mentioned on Slack:

@koke koke merged commit eaf8da8 into develop May 31, 2019
@koke koke deleted the gutenberg-1.6.0 branch May 31, 2019 08:06
@CHaNGeTe
Copy link

CHaNGeTe commented Jul 6, 2019

Video seems to have no sound. Known issue at TheWidlarzGroup/react-native-video#1192

Try this PR:
TheWidlarzGroup/react-native-video#1654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants