Prevent "Undo Level" after Setting Featured Image via Image Block #15072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new sentence added here will serve to notify users of the undo/redo limitations after setting an image as featured via the image block.
SiobhyB
added
[Type] Bug
Gutenberg
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
added 4 commits
July 26, 2021 17:19
With this commit, the text from "string.notice_undo_limitations" is added, via concatenation, to the existing text for the notice that displays when a image is set as featured via the image block.
The aim of this commit is to make the text associated with each showNotice() function more readable, by moving each piece to its own individual variable.
The goal is to make it clearer to users that this text is "secondary" in its importance and can be skimmed.
With this commit, we're removing the changes that were made to the notice's text in the previous commit. This follows the discussion found in the commnts of the related PR: WordPress/gutenberg#33057 (comment)
…' of github.com:wordpress-mobile/WordPress-Android into gutenberg/32937-featured-button-undo-redo-functionality
…' of github.com:wordpress-mobile/WordPress-Android into gutenberg/32937-featured-button-undo-redo-functionality
Generated by 🚫 dangerJS |
|
@SiobhyB I see that this PR only bumps the Gutenberg Mobile reference, which will be already done when cutting a new Gutenberg Mobile release so probably it won't be necessary to merge it. Please let me know if you still would like to have this reviewed and merged into WPAndroid. |
|
@fluiddot, you're right, no need to review and merge this one! It was originally created when the plan was to add text to the "notice" but is no longer needed. I'll go ahead to close. :) |
fluiddot
deleted the
gutenberg/32937-featured-button-undo-redo-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended as a temporary workaround for WordPress/gutenberg#32937
gutenberg: WordPress/gutenberg#33057gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3682Description
As outlined in WordPress/gutenberg#32937, the undo/redo functionality doesn't work as expected after setting a featured image via the image block.
After setting a featured image via the block and then tapping undo, it appears as though the action has successfully reverted, as the Featured banner is removed from the block. However, the image still remains as the post's featured image.
With this PR, the issue is worked around by preventing an "undo level" from being created after a featured image is set via the image block. Tapping undo or redo immediately after setting a featured image via the image block should no longer have any effect.
See the Gutenberg PR for further details.
Testing
To test: Please refer to the Gutenberg PR as the most central, up-to-date place for testing instructions.
Regression Notes
As we're changing the default behaviour of the undo/redo functionality, there's some possibility for unintended side effects to that functionality.
I relied on manual testing to confirm that the undo/redo functionality worked as expected.
The changes are relatively small and don't warrant automated tests.
PR submission checklist:
RELEASE-NOTES.txtif necessary.