-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Proguard rules for React Native's Reanimated library #16578
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
-keep class com.swmansion.reanimated.** { *; } | ||
-keep class com.facebook.react.turbomodule.** { *; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rules have been added following the installation guide of the Reanimated library:
https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/installation/#proguard
You can test the changes on this Pull Request by downloading the APKs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I did a release build locally and observed that dragging and dropping was working great! 🎉
This fix has now been shipped as part of the |
This PR fixes a crash related to dragging a block in the editor.
To test
Preparation:
Proguard rules are only applied in the release version, so in order to test the change properly, it's required either to build the app in release mode or build the app locally and enable Proguard by applying the following patch.
Testing instructions:
Regression Notes
Potential unintended areas of impact
This PR only adds a couple of Proguard rules so there are no potential unintended areas of impact.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.