[Nullability Annotations to Java Classes] Update wordPressLintVersion to 2.0.0
#19434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Notes: https://github.com/wordpress-mobile/ WordPress-Lint-Android/releases/tag/2.0.0
Generated by 🚫 dangerJS |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19434-b8d88b1 | |
| Commit | b8d88b1 | |
| Direct Download | jetpack-prototype-build-pr19434-b8d88b1.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19434-b8d88b1 | |
| Commit | b8d88b1 | |
| Direct Download | wordpress-prototype-build-pr19434-b8d88b1.apk |
|
Thanks
…On Tue, Oct 24, 2023, 6:27 PM peril-wordpress-mobile[bot] < ***@***.***> wrote:
Warnings
|
wzieba
approved these changes
Oct 25, 2023
Comment on lines
+25
to
+36
| <issue id="MissingNullAnnotationOnField"> | ||
| <ignore path="**/generated/**" /> | ||
| </issue> | ||
| <issue id="MissingNullAnnotationOnConstructorParameter"> | ||
| <ignore path="**/generated/**" /> | ||
| </issue> | ||
| <issue id="MissingNullAnnotationOnMethodParameter"> | ||
| <ignore path="**/generated/**" /> | ||
| </issue> | ||
| <issue id="MissingNullAnnotationOnMethodReturnType"> | ||
| <ignore path="**/generated/**" /> | ||
| </issue> |
There was a problem hiding this comment.
Would it be possible to add this config as a part of wordPressLintVersion? I think that we never really want to lint generated code in any way.
There was a problem hiding this comment.
Good question @wzieba ! 💯
TL:DR: We had a looooong discussion about that and ended-up merging this Lint rule without it, you could check this last comment on it, and all the relevant comments further up, I think you'll get the idea and the why behind this decision.
Hmmm... I didn't think of that, which is the fact that having checkGeneratedSources = true might be causing all this, very interesting! 🤔
Let me know if that makes sense to you too. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #18904
Closes #19025
This PR updates
wordPressLintVersionto 2.0.0.To test:
Lintrelated checks JP + WP and their reports: Jetpack + WordPress).MissingNullAnnotationOn*correctness related rules are reporting as expected. For a reference, see screenshot below:Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: