Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GB version to support list blocks #11409

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Conversation

SergioEstevao
Copy link
Contributor

Fixes wordpress-mobile/gutenberg-mobile#208

Related GB-mobile PR: wordpress-mobile/gutenberg-mobile#704

To test:

  • Create a new post using GB
  • Add a list block to it
  • See if it shows correctly
  • Add list items
  • Change type of list (ordered, unordered)
  • Split list items in the middle
  • Split block by inserting two empty list items

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the Gutenberg Editing and display of Gutenberg blocks. label Apr 5, 2019
@SergioEstevao SergioEstevao added this to the 12.2 milestone Apr 5, 2019
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SergioEstevao - Lists are working great! 🎉

I have one question:

When splitting the list block, I get a paragraph block in the middle. Also, when splitting an ordered list, the second half is converted into an unordered list. I'm not sure if that's expected or a known issue.

If it is, let's :shipit:
If it's not, I guess we can create a new tickets and :shipit: 😁

splitting_list

@etoledom
Copy link
Contributor

etoledom commented Apr 5, 2019

An example with ordered list:

splitting_ordered

@SergioEstevao
Copy link
Contributor Author

@etoledom both your findings also happen on the web version, so I assume that is by design :).

Thanks for the review!

@hypest
Copy link
Contributor

hypest commented Apr 5, 2019

The ordered-list-becomes-unordered-on-split feels like a bug. @ellatrix maybe you have some clue on this one?

@ellatrix
Copy link

ellatrix commented Apr 5, 2019

When splitting the list block, I get a paragraph block in the middle.

What's not expected about this? What do you expect?

Also, when splitting an ordered list, the second half is converted into an unordered list.

@hypest @SergioEstevao I don't see this happening for web.

@etoledom
Copy link
Contributor

etoledom commented Apr 5, 2019

When splitting the list block, I get a paragraph block in the middle.

What's not expected about this? What do you expect?

My first expectation was to have just two list blocks, as when splitting a paragraph block. But on a second thought, it makes total sense. If I split a list, it would most probably be to write something in between. 👍

@ellatrix
Copy link

ellatrix commented Apr 5, 2019

@etoledom It's the same in most editors I've come across. :)

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Apr 5, 2019

@hypest @SergioEstevao I don't see this happening for web.

@ellatrix

I just tested in WP.com and saw this happening:

Create a list block
Make it a numbered one
Write some lines/items
Split the list in the middle.
The bottom part gets converted to a bullet list.

@hypest
Copy link
Contributor

hypest commented Apr 5, 2019

Also, when splitting an ordered list, the second half is converted into an unordered list.

@hypest @SergioEstevao I don't see this happening for web.

Here's what I see on the web (Frontenberg) at the time of writing @ellatrix when I hit "Enter" two times in a middle list item:

list-block-split-numbers-to-bullets

The second half of the ordered list becomes unordered. Not sure if Frontenberg has the latest of Gutenberg or this behavior is by design.

@ellatrix
Copy link

ellatrix commented Apr 5, 2019

@hypest Ah, I was on a different branch. Looks like WordPress/gutenberg#14840 fixes it.

@SergioEstevao SergioEstevao merged commit 10f4fde into develop Apr 5, 2019
@SergioEstevao SergioEstevao deleted the gutenberg/208_lists branch April 5, 2019 13:34
@ellatrix
Copy link

ellatrix commented Apr 5, 2019

@hypest Added a test: WordPress/gutenberg@1aec480

Would appreciate a review of the PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants