Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg/1.14.0 #12574

Merged
merged 12 commits into from
Oct 4, 2019
Merged

Gutenberg/1.14.0 #12574

merged 12 commits into from
Oct 4, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Sep 30, 2019

This PR updates the gutenberg-mobile reference to point to the latest release, v1.14.0.

The reference is currently pointing to the release/1.14.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: wordpress-mobile/gutenberg-mobile#1392.

To test:
The block editor should work as normal.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@marecar3 marecar3 added the Gutenberg Editing and display of Gutenberg blocks. label Sep 30, 2019
@marecar3 marecar3 added this to the 13.4 milestone Sep 30, 2019
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested this and everything appears to be working. My only concern is whether we are missing the release notes for @SergioEstevao 's link handling fixes. I think we need those. WDYT?

@etoledom
Copy link
Contributor

etoledom commented Oct 2, 2019

I've found some known issues on this release. Not sure if we want to ship these:

Also this one, but It's already on production (not a regression):

@etoledom
Copy link
Contributor

etoledom commented Oct 4, 2019

I noticed that the fix applied on WordPress/gutenberg#17710 for this issue: wordpress-mobile/gutenberg-mobile#1399 is not working.

Did an investigation and sent a PR to fix it: WordPress/gutenberg#17763

cc @marecar3 @SergioEstevao

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the last update 5655d94, all the current issues were solved 🎉

Thank you everyone! LGTM :shipit:

@etoledom etoledom merged commit 86fdc27 into develop Oct 4, 2019
@etoledom etoledom deleted the gutenberg/1.14.0 branch October 4, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants