Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Podfile to support RN-0.61 #13116

Merged
merged 11 commits into from
Jan 24, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Dec 16, 2019

This PR updates the RN libraries references in the podfile Gutenberg section to make sure they follow the new names and needs of the new version.

To test:

  • Delete the pods folder: rm -Rf Pods. This updates brings a a lot of pod change for RN so it's better to start with a clean folder.
  • Run rake dependencies
  • Make sure the project builds
  • Make sure you can open a GB post.
  • Smoke test the functionality on the GB editor.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the Gutenberg Editing and display of Gutenberg blocks. label Dec 16, 2019
@SergioEstevao SergioEstevao added this to the 14.0 milestone Dec 16, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 16, 2019

You can trigger an installable build for these changes by visiting CircleCI here.

@loremattei loremattei modified the milestones: 14.0 ❄️, 14.1 Jan 13, 2020
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Project builds and run! 🎉
  • Gutenberg opens and works well 🎉 🎉

rm -rf Pods was needed to properly run rake dependencies, other than that, everything looks great .
:shipit: 🎉 🎉 🎉

@etoledom
Copy link
Contributor

Let's wait for the WPiOS code freeze to merge this, or target and merge to gutenberg/after-1.21.0.

@SergioEstevao SergioEstevao changed the base branch from develop to gutenberg/after-1.21.0 January 23, 2020 10:51
@hypest
Copy link
Contributor

hypest commented Jan 23, 2020

Yeap, let's target the gutenberg/after-1.21.0 branch (Sérgio already did it in the meantime) so we only merge this to the main app only after the main app freeze.

@hypest hypest merged commit fca8987 into gutenberg/after-1.21.0 Jan 24, 2020
@hypest hypest deleted the gutenberg/try_rn_update_to_0.61 branch January 24, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants