Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: update to v1.22.0 #13353

Merged
merged 12 commits into from
Feb 8, 2020
Merged

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 3, 2020

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1849

Changes

  • gb-mobile-1830 (DEV only) Fix gallery upload sync
  • gb-mobile-1686 Adding retry feature to mobile apiFetch handler
  • gb-mobile-1847 Remove DEV flag from Media Editor button
  • gb-mobile-1841 Show the media edit icon only if the block is selected
  • gb-mobile-1817 External media links from another app will not work if the block editor is enabled
  • gb-mobile-1835 Make inserter to show options on long-press to add before/after
  • gb-mobile-1825 (DEV only) Fix: fix appender style
  • gb-mobile-1826 Update ref to react-native-slider fork to support autolinking
  • gb-mobile-1827 Fixes the Image's media button not displaying the Picker
  • gb-mobile-1872 Add media edit icon to image block
  • gb-mobile-1821 Fix: AppenderButton and Separator in InnerBlock
  • gb-mobile-1776 (DEV only) Allow configuration of selection/caret color on Aztec view
  • gb-mobile-1450 Update React Native to 0.61.5
  • gb-mobile-1785 (DEV only) Style improvements for template previews
  • gb-mobile-1799 Adjust to Gutenberg master to fix issues with icons, the primitives package and a new dependency for data
  • gb-mobile-1762 (DEV only) Use patch-package to fix max-depth issue in react-native (temporary)
  • gb-mobile-1786 Hardcode Android RN version in bridge and aztec

Changes - After the cut was started

To test:

  • Smoke test the app and report if all OK
  • Please try the items in the changelog above and report the test outcome of each one that you tested

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added the Gutenberg Editing and display of Gutenberg blocks. label Feb 3, 2020
@hypest hypest added this to the 14.2 milestone Feb 3, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 3, 2020

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 22268. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@hypest hypest marked this pull request as ready for review February 3, 2020 15:25
@hypest
Copy link
Contributor Author

hypest commented Feb 6, 2020

Tested 4faa77d:

Legend:
🤷‍♂️ : not exposed to the apps yet
⏳ : in progress
❌ : failed
✅ : passes
⚠️ : passes but there are notes
🚫 : blocked

⏳ Smoke test
🚫 gb_mobile_1686 Adding retry feature to mobile apiFetch handler. 🚫: Testing instructions assume the WP Media library will allow selecting an image while offline but, it doesn't in my test
gb_mobile_1847 Remove DEV flag from Media Editor button
gb_mobile_1841 Show the media edit icon only if the block is selected
gb_mobile_1835 Make inserter to show options on long-press to add before/after
gb_mobile_1826 Update ref to react-native-slider fork to support autolinking
gb_mobile_1827 Fixes the Image's media button not displaying the Picker
gb_mobile_1872 Add media edit icon to image block
gb_mobile_1450 Update React Native to 0.61.5
gb_mobile_1799 Adjust to Gutenberg master to fix issues with icons, the primitives package and a new dependency for data
gb-mobile-1856 Fix gallery size labels (tested on 4582b9b)


🤷‍♂️ gb_mobile_1817 External media links from another app will not work if the block editor is enabled. Fixes an Android-only issue
🤷‍♂️ gb_mobile_1830 (DEV only) Fix gallery upload sync
🤷‍♂️ gb_mobile_1825 (DEV only) Fix: fix appender style
🤷‍♂️ gb_mobile_1776 (DEV only) Allow configuration of selection/caret color on Aztec view
🤷‍♂️ gb_mobile_1785 (DEV only) Style improvements for template previews
🤷‍♂️ gb_mobile_1762 (DEV only) Use patch-package to fix max-depth issue in react-native (temporary)
🤷‍♂️ gb_mobile_1821 (DEV only) Fix: AppenderButton and Separator in InnerBlock

@etoledom
Copy link
Contributor

etoledom commented Feb 7, 2020

Testing issues found on WPAndroid wordpress-mobile/WordPress-Android#11224 (comment):

  1. Typing "Enter" to create a new paragraph block causes the blocks list to jump to the top and scroll down to the new block.

This issue is also present on WPiOS

jumpy

  1. Merging blocks by hitting "backspace" doesn't work if you first edit one or more chars from the start of the block. (Not on WPiOS)
  2. Quote block "jumping/quirk" trying to add a newline. This seems to already exist in the production app as well.

I didn't find any jumpiness/quirkiness, but there's a small flashiness on the last line. I believe this is an old thing that doesn't seem to be problematic.
flash2

  1. Keyboard doesn't hide when hitting the "close keyboard" button on the toolbar while being in the shortcode block and the Image caption (same on Code block but that block is behind "DEV" flag). (Not on WPiOS, also tested on Pre-formatted, and the keyboard shows [the field is focused] when the blocks are inserted).

@etoledom
Copy link
Contributor

etoledom commented Feb 7, 2020

  1. Jumpines on new para block:

It's an old known bug described here: facebook/react-native#24011

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest build looks good, ready to merge!

@mchowning mchowning merged commit 7a45c07 into develop Feb 8, 2020
@mchowning mchowning deleted the gutenberg/integrate_release_1.22.0 branch February 8, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants