Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Fix editor launch freeze in debug mode when packager isn't running #16094

Closed
wants to merge 2 commits into from
Closed

[Gutenberg] Fix editor launch freeze in debug mode when packager isn't running #16094

wants to merge 2 commits into from

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Mar 15, 2021

See gb-mobile PR for more information: wordpress-mobile/gutenberg-mobile#3258

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Mar 15, 2021
@ceyhun ceyhun requested a review from guarani March 15, 2021 08:26
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 15, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 44627. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@ceyhun ceyhun mentioned this pull request Mar 15, 2021
Merged
2 tasks
@peril-wordpress-mobile
Copy link

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 15, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

guarani
guarani approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well! I take it this won't be merged, but approving anyway 👍

@ceyhun
Copy link
Contributor Author

ceyhun commented Mar 31, 2021

Main PRs are merged, closing this as it doesn't include any WPiOS specific changes and this fix should be included in WPiOS with the Gutenberg 1.50 release.

@ceyhun ceyhun closed this Mar 31, 2021
@ceyhun ceyhun deleted the gutenberg/fix-dev-freeze branch March 31, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceyhun @guarani