Merge finalized release/19.8

[AliSoftware]

• Fastlane localized release_notes.txt updates — though most of them came in during the last beta merged yesterday
• Localized .strings updates — though most of them came in during the last beta merged yesterday
• Build number bump in version .xcconfig file
• Diffs from the PRs that landed on the release branch since the last beta — None

---

You'll notice that the localized metadata for es-MX was deleted.

Indeed, when I ran `fastlane finalize_release`, this was in the logs

[17:58:57]: ---------------------------------
[17:58:57]: --- Step: gp_downloadmetadata ---
[17:58:57]: ---------------------------------
[17:58:57]: Project URL: https://translate.wordpress.org/projects/apps/ios/release-notes/
[17:58:57]: Locales: {"ar"=>"ar-SA", "da"=>"da", "de"=>"de-DE", "en-au"=>"en-AU", "en-ca"=>"en-CA", "en-gb"=>"en-GB", "es"=>"es-ES", "es-mx"=>"es-MX", "fr"=>"fr-FR", "he"=>"he", "id"=>"id", "it"=>"it", "ja"=>"ja", "ko"=>"ko", "nl"=>"nl-NL", "nb"=>"no", "pt-br"=>"pt-BR", "pt"=>"pt-PT", "ru"=>"ru", "sv"=>"sv", "th"=>"th", "tr"=>"tr", "zh-cn"=>"zh-Hans", "zh-tw"=>"zh-Hant"}
[17:58:57]: Source locale: -
[17:58:57]: Path: /Users/olivier/Documents/Dev/apps/WordPress-iOS/fastlane/metadata
Downloading language: ar-SA
Downloading language: da
Downloading language: de-DE
Downloading language: en-AU
Downloading language: en-CA
Downloading language: en-GB
Downloading language: es-ES
Downloading language: es-MX
[17:59:05]: No translation available for es-MX
Downloading language: fr-FR
Downloading language: he
Downloading language: id
Downloading language: it
Downloading language: ja
Downloading language: ko
Downloading language: nl-NL
Downloading language: no
Downloading language: pt-BR
Downloading language: pt-PT
Downloading language: ru
Downloading language: sv
Downloading language: th
Downloading language: tr
Downloading language: zh-Hans
Downloading language: zh-Hant

I'm not sure what happened here, because if I look in GlotPress, the translations for those are present, so no sure why the logs said "No translation available for es-MX" after all.

My best guess is that we encountered the "429 Too Many Requests" error from GlotPress again, except on gp_downloadmetadata this time; and likely our gp_downloadmetadata action just prints a generic "no translation available for …" message for anything other than 200 OK regardless of the actual error status code (likely 429 here)

By the time I realized that (i.e. when I submitted the App for review and when I opened this PR) it was already too late, and also I'm wayyyy past EOD already, so I figured I'd leave it that way for this cycle — which means es-MX will have the app title in English in AppStore for a sprint and it will be back to Mexican Spanish translation next sprint. 🤷

[peril-wordpress-mobile]

	Messages
📖	This PR has the 'Releases' label: some checks will be skipped.

Generated by 🚫 dangerJS

[AliSoftware]

My guess is this was deleted because of another case of 429 Too Many Requests on es-MX, and gp_downloadmetadata treating any error without distinction as "no translation", hence this quite silent deletion during fastlane finalize_release.

See PR description for details.

[AliSoftware]

See PR description for guess at why that was deleted.

[AliSoftware]

See PR description for guess at why that was deleted.

[AliSoftware]

See PR description for guess at why that was deleted.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr18612-75641f0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr18612-75641f0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[mokagio]

Thank you for looking over this @AliSoftware 👍

+1 on the es-MX compromise. Our "tight" release cadence lets us swallow those kind of things because they won't be around for long anyway.