Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Add React Native FastImage #18995

Merged
merged 5 commits into from
Jul 11, 2022
Merged

[Gutenberg] Add React Native FastImage #18995

merged 5 commits into from
Jul 11, 2022

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jul 6, 2022 •
edited
Loading

Work in progress...

It adds support for the React Native FastImage library.

To test check the Gutenberg PR description.

Regression Notes

  1. Potential unintended areas of impact
  • Block editor and image rendering
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Manual testing
  • Check E2E tests pass correctly
  1. What automated tests I added (or what prevented me from doing so)
  • None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Jul 6, 2022
This was referenced Jul 6, 2022
Merged
Merged
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 6, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18995-2f12a30 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 6, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18995-2f12a30 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@geriux geriux requested a review from derekblank July 7, 2022 14:13
@geriux geriux added this to the 20.4 milestone Jul 7, 2022
@geriux geriux marked this pull request as ready for review July 7, 2022 14:13
derekblank
derekblank approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@geriux geriux merged commit ac84f8a into trunk Jul 11, 2022
@geriux geriux deleted the gutenberg/add-react-native-fast-image branch July 11, 2022 16:40
@derekblank derekblank mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
20.4
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @wpmobilebot @derekblank