Fix flaky testCreateBlankPage #22983
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
testCreateBlankPage()
.To test:
RCA
setUpTestSuite(selectWPComSite: WPUITestCredentials.testWPcomFreeSite)
launches the app and nearly instantly logs the user in (which is awesome – thank you!)initial_pages_list
statetry await WireMock.setUpScenario(scenario: "new_page_flow")
and reset the scenario state back to "Started"As a result, the mock server returns the following error when you try to upload a post:
It's a race condition and it depends on whether the pages are fetched before or after the reset happens.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: