iOS 18 Support #23527

jkmassel · 2024-08-28T19:34:17Z

Adds iOS 18 support – we're not building against that SDK yet, but right now this PR:

Adds iOS 18 tint-able icons
Builds the app with Xcode 16

To test:
Ensure CI passes

dangermattic · 2024-08-28T19:34:58Z

	3 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 25.4. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

wpmobilebot · 2024-08-28T19:51:25Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23527-d2410ee
	Version	25.3
	Bundle ID	org.wordpress.alpha
	Commit	`d2410ee`
	App Center Build	WPiOS - One-Offs #10727

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2024-08-28T19:51:33Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23527-d2410ee
	Version	25.3
	Bundle ID	com.jetpack.alpha
	Commit	`d2410ee`
	App Center Build	jetpack-installable-builds #9771

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

`cache` is actor-isolated, so it can’t be acessed from a `nonisolated` function without using `await` I just re-isolated it and updated the callers

kean

I made some more minor changes and updated the .xcode-version. The icons looks good, and everything else too.

WordPress/Classes/Utility/ImmuTable.swift

crazytonyli · 2024-09-19T23:22:26Z

WordPress/Classes/Utility/ImmuTable.swift

@@ -486,6 +486,10 @@ extension UITableViewController: TableViewContainer {}

 // MARK: - Diffable

+// This conformance was added during the Xcode 16 migration to silence the
+// dozens of false-positive warnigns (any @unchecked conformance is tech debt).
+extension AnyHashable: @retroactive @unchecked Sendable {}


This line has a much bigger impact than the individual @checked Sendable: all AnyHashable instances now get Sendable during runtime, which feels like an unsafe change...

I don't have any solution to solve the warning without changing how the two types below are used. Maybe we can tolerate the warnings for now until a proper ImmuTable refactor?

all AnyHashable instances now get Sendable during runtime, which feels like an unsafe change

It brings the app back to the status quo where in Xcode 15.4 where all AnyHashable instances were also not producing any concurrency warnings.

Maybe we can tolerate the warnings for now until a proper ImmuTable refactor?

Unfortunately no because the vast majority of warnings are due to this type.

I don't have any solution to solve the warning without changing how the two types below are used.

The problem is two-fold:

UITableViewDiffableDataSource requiring Sendable even when you never use it from the background (you can but very few people actually do). I think it's a pretty major limitation of the design of data race safety features in Swift 6.

AnyHashable can't become Sendable conditionally based on the type is is parameterized with because it erases this type at compile time.

The only fix seems to be to stop using AnyHashable.

Co-authored-by: Tony Li <tony.li@automattic.com>

…sidebar

kean · 2024-09-24T12:06:24Z

.buildkite/pipeline.yml

@@ -79,7 +79,7 @@ steps:
              context: "UI Tests (iPhone)"

      - label: "🔬 :jetpack: UI Tests (iPad)"
-        command: .buildkite/commands/run-ui-tests.sh 'iPad Pro 13-inch (M4)'
+        command: .buildkite/commands/run-ui-tests.sh 'iPad (10th generation) (17.5)'


I stopped trying to get it to work because I have another branch where I remove the .sidebar FF and with a fully updated set of tests.

kean · 2024-09-24T13:09:58Z

WordPress/WordPressTest/Comments/Controllers/FullScreenCommentReplyViewControllerTests.swift

-        let view = controller.navigationController?.view.subviews.first { view in
-            return view is SuggestionsTableView
-        }
-        let suggestionsTableView = try XCTUnwrap(view)


I spent a good hour trying to debug this but because these tests don't follow best practices for unit testing and are evaluating the UIKit components, I made a call to remove them.

kean · 2024-09-24T13:10:49Z

WordPress/WordPressTest/Notification/Controllers/NotificationsViewControllerTests.swift

@@ -52,6 +52,13 @@ final class NotificationsViewControllerTests: XCTestCase {
        postAccountChangeNotification()

        // Then
+        // TODO: rework this unit test
+        let expectation = self.expectation(description: "setBadgeCount")
+        DispatchQueue.main.asyncAfter(deadline: .now() + .milliseconds(100)) {


These tests are failing because the deprecated applicationIconBadgeNumber property now works asynchronously. It's not great, but we can rework it when we remove the deprecated API.

…rmatting)

jkmassel added 2 commits August 28, 2024 13:34

Use iOS 18 icon

e72e4a5

Build with Xcode 16

51d0043

jkmassel force-pushed the ios-18-changes branch from e3bfbd8 to 51d0043 Compare August 28, 2024 19:34

jkmassel and others added 10 commits August 28, 2024 14:03

Fix Swift 6 language mode warnings

07cde1f

Fix ImageDownloader Swift 6 warnings

c4e89ec

`cache` is actor-isolated, so it can’t be acessed from a `nonisolated` function without using `await` I just re-isolated it and updated the callers

Adds a @sendable conformance so that tests build

a3efee1

Fix an Swift 6 warning

93e2314

Specify the iOS deployment target

397cf22

Add retroactive conformance annotations

88f3612

Added some straightforward sendable conformance

453f8e9

Merge branch 'trunk' into ios-18-changes

9d9eb82

Update .xcode-version

00c7103

Add nonisolated to ImageDownloader caching methods

b7e09f5

kean force-pushed the ios-18-changes branch from 9d2a4be to b7e09f5 Compare September 19, 2024 10:31

kean added 7 commits September 19, 2024 06:51

Address warnings

377e6b6

Silence warnings

77db597

Addess more concurrency warnings

1dccccf

Fix more warnings

032dc94

Fix shared-pipeline-vars

cee7bc7

Fix unit tests

0d693d6

Fix warnings in tests

909eee9

kean marked this pull request as ready for review September 19, 2024 12:44

kean requested review from kean and crazytonyli and removed request for kean September 19, 2024 12:44

Remove weird unit tests in WordPressAuthenticator

894abe5

kean self-requested a review September 19, 2024 13:32

kean approved these changes Sep 19, 2024

View reviewed changes

kean added the General label Sep 19, 2024

kean added this to the 25.4 milestone Sep 19, 2024

Update unit test device

a80f78f

crazytonyli reviewed Sep 19, 2024

View reviewed changes

Update WordPress/Classes/Utility/ImmuTable.swift

3c2a2d1

Co-authored-by: Tony Li <tony.li@automattic.com>

kean enabled auto-merge September 23, 2024 16:10

kean added 6 commits September 23, 2024 17:07

Remove broken tests (no following best practices for unit testing)

de441a2

Update xcode version

b2b6cec

Update names of test devices

cd51be7

Add a workaround for testResetApplicationBadgeWhenAccountChange test

6aa329b

Merge branch 'trunk' into ios-18-changes

0fc64d5

Update iPad to run on iOS 17.5 until we can update the tests for the …

26882c7

…sidebar

kean reviewed Sep 24, 2024

View reviewed changes

Updates tests in testTrafficYearsStatsLoadProperly (for new number fo…

72bdd6d

…rmatting)

kean force-pushed the ios-18-changes branch 2 times, most recently from a749182 to a3778b7 Compare September 24, 2024 19:58

Temporarily disable tests on iPad

d2410ee

kean force-pushed the ios-18-changes branch from a3778b7 to d2410ee Compare September 24, 2024 20:01

kean added this pull request to the merge queue Sep 24, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024

kean added this pull request to the merge queue Sep 24, 2024

Merged via the queue into trunk with commit 3c8276c Sep 24, 2024
24 checks passed

kean deleted the ios-18-changes branch September 24, 2024 21:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS 18 Support #23527

iOS 18 Support #23527

jkmassel commented Aug 28, 2024

dangermattic commented Aug 28, 2024 •

edited

Loading

wpmobilebot commented Aug 28, 2024 •

edited

Loading

wpmobilebot commented Aug 28, 2024 •

edited

Loading

kean left a comment

crazytonyli Sep 19, 2024

kean Sep 19, 2024 •

edited

Loading

kean Sep 24, 2024 •

edited

Loading

kean Sep 24, 2024

kean Sep 24, 2024

iOS 18 Support #23527

iOS 18 Support #23527

Conversation

jkmassel commented Aug 28, 2024

dangermattic commented Aug 28, 2024 • edited Loading

wpmobilebot commented Aug 28, 2024 • edited Loading

wpmobilebot commented Aug 28, 2024 • edited Loading

kean left a comment

Choose a reason for hiding this comment

crazytonyli Sep 19, 2024

Choose a reason for hiding this comment

kean Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

kean Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

kean Sep 24, 2024

Choose a reason for hiding this comment

kean Sep 24, 2024

Choose a reason for hiding this comment

dangermattic commented Aug 28, 2024 •

edited

Loading

wpmobilebot commented Aug 28, 2024 •

edited

Loading

wpmobilebot commented Aug 28, 2024 •

edited

Loading

kean Sep 19, 2024 •

edited

Loading

kean Sep 24, 2024 •

edited

Loading