Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Rename showPostTab #23616

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Refactor: Rename showPostTab #23616

wants to merge 1 commit into from

Conversation

kean
Copy link
Contributor

@kean kean commented Sep 18, 2024

It is not longer a tab, so the naming is confusing. I also removed the redundant variants.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the Pending milestone Sep 18, 2024
kean
kean commented Sep 18, 2024
View reviewed changes
WordPress/Classes/System/RootViewPresenter+EditorNavigation.swift
func showPostTab(completion afterDismiss: (() -> Void)?) {
let context = ContextManager.shared.mainContext
// Ignore taps on the post tab and instead show the modal.
if Blog.count(in: context) > 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There used to be a second branch here that I removed. The method that it called returns if there are no sites, so there is no need to repeat this code.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23616-034b92d
Version25.3
Bundle IDorg.wordpress.alpha
Commit034b92d
App Center BuildWPiOS - One-Offs #10704
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23616-034b92d
Version25.3
Bundle IDcom.jetpack.alpha
Commit034b92d
App Center Buildjetpack-installable-builds #9748
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
General [Type] Tech Debt
Projects
None yet
Milestone
Pending
Development

Successfully merging this pull request may close these issues.
2 participants
@kean @wpmobilebot