Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dark mode color #23619

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Update dark mode color #23619

merged 1 commit into from
Sep 20, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Sep 20, 2024

I cherry-picked the change from #23587, but only for Jetpack for now. I've been testing the dark mode version extensively on my personal devices, and the current green does appear too dark and it not legible. You typically want to use colors that are slightly lighter in dark mode, so this PR does that.

Screenshot 2024-09-19 at 9 29 31 PM

The color in light mode is unchanged.

Screenshot 2024-09-19 at 9 29 16 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Sep 20, 2024
@kean kean added this to the 25.4 milestone Sep 20, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23619-4d165c7
Version25.3
Bundle IDorg.wordpress.alpha
Commit4d165c7
App Center BuildWPiOS - One-Offs #10717
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23619-4d165c7
Version25.3
Bundle IDcom.jetpack.alpha
Commit4d165c7
App Center Buildjetpack-installable-builds #9760
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge September 20, 2024 15:56
@kean kean added this pull request to the merge queue Sep 20, 2024
Merged via the queue into trunk with commit 8349be8 Sep 20, 2024
26 checks passed
@kean kean deleted the task/color-dark-mode branch September 20, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants