Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new site plugins list #24023

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

crazytonyli
Copy link
Contributor

Note

This PR is built on top of #24014.

The new screen follows the pattern established in the self-hosted site User Management. An application password is required to access this feature (when it's turned on).

Here is a recording of this screen:

plugins.mp4

As part of this PR, I made a small change to CachedAsyncImage. It now accepts an interim object (ImageURLResolver), which eventually produces an image URL. The icons in the plugin list is not part of the plugins response. Their url has to be loaded separately.

I could spin up separate tasks to load them and then refresh the plugins list after they are loaded. But I thought making them part of the image loading process might be more straightforward in terms of managing the loading tasks: SwiftUI would take care of them.

Of course, that comes with a downside: All URLs are put into an async call, which is definitely slower than just using them directly in the calling thread. But I thought that's an okay compromise to make.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.8 milestone Jan 29, 2025
@crazytonyli crazytonyli requested review from jkmassel and kean January 29, 2025 01:00
@crazytonyli crazytonyli marked this pull request as ready for review January 29, 2025 01:01
@crazytonyli crazytonyli changed the title Self hosted site plugin management @crazytonyli Implement a new site plugins list Jan 29, 2025
@crazytonyli crazytonyli changed the title @crazytonyli Implement a new site plugins list Implement a new site plugins list Jan 29, 2025
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 29, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24023-9056952
Version25.7
Bundle IDorg.wordpress.alpha
Commit9056952
App Center BuildWPiOS - One-Offs #11423
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 29, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24023-9056952
Version25.7
Bundle IDcom.jetpack.alpha
Commit9056952
App Center Buildjetpack-installable-builds #10456
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@crazytonyli crazytonyli force-pushed the self-hosted-site-plugin-management branch from 04dc5bf to 29e57ce Compare January 29, 2025 08:17
Base automatically changed from move/users-to-module to trunk January 29, 2025 20:21
@crazytonyli crazytonyli force-pushed the self-hosted-site-plugin-management branch from 29e57ce to 9056952 Compare January 29, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants