Introducing PingHub (...and friends) #6331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I reached the limits of what you can sanely achieve with Cocoapods. I split PingHub into a separate project to keep things organized, and Cocoapods didn't like that much. Apparently you can't have a framework target that embeds it's dependencies unless you copy them manually, which kind of defeats the purpose of having Cocoapods to manage them. So I introduce Carthage/Punic for Starscream on PingHub. And now, we are one step closer of saying goodbye to Cocoapods.
WordPress wasn't picking the right one, so I removed it and re-added the framework and it works now ¯\_(ツ)_/¯
|
Buddybuild is failing to run the test suite although it works locally. I'll investigate tomorrow |
This was referenced Dec 15, 2016
|
Closing in favor of #6336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first basic approach to #6164. I've added the PingHub client and very basic logic:
Things I haven't done yet:
Also, Carthage. Because Cocoapods won't let me have it my way.
We've chatted about this a few times, and I'd like to propose we start using more frameworks but not more repos, and this is my take on it. I started adding a PingHub target, but I also wanted tests, so that was 2 more targets. Which could be fine for now, but I think it might get noisy if we do a few more components. So I'd rather have a separate project. I think this will also help if we want the framework to support being a Cocoapods/Carthage dependency, but I haven't explored that yet.
Cocoapods won't let me have a framework with an embedded framework, so instead of working around Cococapods one more time I decided to include Starscream as a binary with Carthage (actually Punic, hence the
punic.yml).To test:
Needs review: @jleandroperez (PingHub) @astralbodies (Project setup, Carthage)