Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery Block: Verify contrast between text and background in dark mode #4310

Closed
SiobhyB opened this issue Nov 29, 2021 · 1 comment
Closed
Labels
Dark mode Tiled Gallery block Issues with this label will automatically appear on the project's board [Type] Discovery

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Nov 29, 2021

While working on Automattic/jetpack#21884, I spotted that the contrast between the Tiled mosaic label and the background was off in dark mode:

I haven't been able to reproduce the issue since creating the PR, but it'd be good to do some more testing to double-check whether there are cases where this is reliably reproducible in dark mode or if it was an edge case. It'd also be good to do more testing in dark mode to see if there are any other issues.

@SiobhyB SiobhyB added Dark mode Jetpack Bug or feature related to Jetpack [Type] Discovery Tiled Gallery block Issues with this label will automatically appear on the project's board and removed Jetpack Bug or feature related to Jetpack labels Nov 29, 2021
@guarani
Copy link
Contributor

guarani commented Nov 29, 2021

Closing in favor of #4276 where I've updated it to include this dark mode issue.

@guarani guarani closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark mode Tiled Gallery block Issues with this label will automatically appear on the project's board [Type] Discovery
Projects
None yet
Development

No branches or pull requests

2 participants