-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Tiled Gallery: Remove "link to" settings and references #21884
[RNMobile] Tiled Gallery: Remove "link to" settings and references #21884
Conversation
For the current phase of the Tiled Gallery block, we won't be shipping the block with link to settings. As such, this commit removes all references to those settings.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via wordpress-mobile/gutenberg-mobile#4304 (review).
Now that the Link To settings have been removing, the border at the bottom of the settings panel appears out of place and can be removed.
Fixes wordpress-mobile/gutenberg-mobile#4281
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4304
As we're not implementing "link to" functionality in this phase of the native Tiled Gallery block (see wordpress-mobile/gutenberg-mobile#4156), this PR removes the setting from the block's bottom sheet as well as all references to it in the code.
Changes proposed in this Pull Request:
LinkSettingsNavigation
component is removed from the Tiled Gallery's settings.LinkSettingsNavigation
component, all references tolinkTo
have also been removed throughout the Tiled Gallery's files.Jetpack product discussion
p9ugOq-1Tb-p2
Does this pull request change what data or activity we track or use?
No, it doesn't.
Testing instructions: