Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Tiled Gallery: Remove "link to" settings and references #21884

Conversation

SiobhyB
Copy link

@SiobhyB SiobhyB commented Nov 26, 2021

Fixes wordpress-mobile/gutenberg-mobile#4281

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4304

As we're not implementing "link to" functionality in this phase of the native Tiled Gallery block (see wordpress-mobile/gutenberg-mobile#4156), this PR removes the setting from the block's bottom sheet as well as all references to it in the code.

Changes proposed in this Pull Request:

Jetpack product discussion

p9ugOq-1Tb-p2

Does this pull request change what data or activity we track or use?

No, it doesn't.

Testing instructions:

  • With these branches checked out and the Gutenberg Mobile demo app running, add the Tiled Gallery block.
  • Select the block's settings cog/gear icon and verify that the "link to" option doesn't appear.
Before After

For the current phase of the Tiled Gallery block, we won't be shipping the block with link to settings. As such, this commit removes all references to those settings.
@SiobhyB SiobhyB changed the base branch from master to rnmobile/add/tiled-gallery-block November 26, 2021 17:21
@github-actions github-actions bot added [Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the Link To settings have been removing, the border at the bottom of the settings panel appears out of place and can be removed.
@SiobhyB SiobhyB merged commit a65afa9 into rnmobile/add/tiled-gallery-block Nov 29, 2021
@SiobhyB SiobhyB deleted the rnmobile/update/tiled-gallery-link-to-settings branch November 29, 2021 22:25
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the "Link to" option from the Tiled Gallery's bottom sheet
3 participants