Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery: Remove "link to" settings and references #4304

Merged

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Nov 26, 2021

Fixes #4281

Jetpack PR: Automattic/jetpack#21884

To test: Please refer to the Jetpack PR as the "central PR" with the most up-to-date testing instructions.


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB changed the base branch from develop to add/tiled-gallery-block November 26, 2021 17:23
@SiobhyB SiobhyB added the Jetpack Bug or feature related to Jetpack label Nov 26, 2021
@SiobhyB SiobhyB self-assigned this Nov 26, 2021
@SiobhyB SiobhyB marked this pull request as ready for review November 26, 2021 17:35
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this change looks good except for one very minor thing: I think the horizontal line spacer needs to be removed now from the bottom of the settings sheet:

Screen Shot 2021-11-29 at 13 59 52

Approving now to let you make this change and merge if you agree.

@guarani
Copy link
Contributor

guarani commented Nov 29, 2021

@SiobhyB, alternatively I think it would be find to merge as-is and create a low-priority issue to follow up on this in the next phase of the project.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 29, 2021

Thanks for the review, Paul! I went ahead to remove the bottom border in Automattic/jetpack@629704e.

@SiobhyB SiobhyB merged commit 96d1a0d into add/tiled-gallery-block Nov 29, 2021
@SiobhyB SiobhyB deleted the update/tiled-gallery-link-to-settings branch November 29, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Bug or feature related to Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the "Link to" option from the Tiled Gallery's bottom sheet
2 participants