Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-load the ReactVideoPackage that got removed by #821 #1016

Merged
merged 1 commit into from
May 22, 2019
Merged

Re-load the ReactVideoPackage that got removed by #821 #1016

merged 1 commit into from
May 22, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented May 22, 2019

Fixes #1015

To test:
Run the demo app on Android. It should normally load without a red screen.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added this to the v1.6 milestone May 22, 2019
@hypest hypest requested a review from mkevins May 22, 2019 05:28
Tug
Tug approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, It works well 👍

@hypest hypest merged commit 96a75be into develop May 22, 2019
@hypest hypest deleted the issue/1015-video-package-not-loaded branch May 22, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

@mkevins mkevins Awaiting requested review from mkevins

Assignees
No one assigned
Labels
[OS] Android
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Red screen on demo app start due to missing video package
2 participants
@hypest @Tug