Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List end test #1022

Merged
merged 2 commits into from
May 23, 2019
Merged

List end test #1022

merged 2 commits into from
May 23, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented May 23, 2019

This PR adds an Appium test for testing the list block ending when inputting an "Enter" at an empty list item where the expectation is that that block should "end" and a new empty paragraph should be created underneath it.

Things to note

  1. The test only really tests the Android side of things as on the iOS we're still missing an implementation of the html check step. See
    async verifyHtmlContent( html: string ) {
    if ( Platform.OS === 'android' ) {
    await this.verifyHtmlContentAndroid( html );
    } else {
    // TODO: implement html verification on iOS too
    }
    }
  2. The new test is added in a new testsuite module (a file separate to the other list test module) because we currently don't have a good way to clean up the state and blocks before starting the next test case. With a separate testsuite, the whole editor is cleaned up by tearing it down and re-starting it. cc @JavonDavis since you've extensively worked on the Appium tests and you might have some ideas and insights on this.

To test:

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added the Testing Anything related to automated tests label May 23, 2019
@hypest hypest added this to the v1.6 milestone May 23, 2019
@hypest hypest requested a review from pinarol May 23, 2019 09:55
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me 🎉

@hypest
Copy link
Contributor Author

hypest commented May 23, 2019

I'll go ahead and merge and in case @JavonDavis has any proposals to make this new test better we can do it in a follow PR.

@hypest hypest merged commit 047a44b into develop May 23, 2019
@hypest hypest deleted the feature/list-end-test branch May 23, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants