Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge yet]Make video block public #1028

Merged
merged 6 commits into from
May 27, 2019
Merged

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented May 24, 2019

This PR removes unregistration of video block for non-dev builds. Generated bundles for test purposes.

gutenberg PR WordPress/gutenberg#15808

Let's merge this after invalid block handling is merged: #1021

To test:

Refer to steps at WPiOS PR: wordpress-mobile/WordPress-iOS#11773

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol pinarol added the Media label May 24, 2019
@pinarol pinarol self-assigned this May 24, 2019
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@pinarol pinarol requested a review from koke May 24, 2019 11:02
@pinarol pinarol changed the title Make video block public [Do not merge yet]Make video block public May 24, 2019
@hypest
Copy link
Contributor

hypest commented May 27, 2019

#1021 is now merged so, will move this PR forward. As discussed over chat last week, I'll take over the updating and merge since Pinar is AFK.

@hypest
Copy link
Contributor

hypest commented May 27, 2019

The failing device tests happen on develop as well so, not blocking this PR, the changes of which don't seem related to the failures anyway.

@hypest hypest merged commit c536f1c into develop May 27, 2019
@hypest hypest deleted the make-video-block-public branch May 27, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants