Fix Android device tests for AndroidX migration #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ndroidx-migration # Conflicts: # __device-tests__/helpers/utils.js
|
Hey, @mkevins 👋I have fixed iOS tests so it seems that we are ready to merge this one in AndroidX branch. |
|
Merging this one in #1112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes e2e Android device tests for the AndroidX migration.
It seems that UI element locators were broken by a change in the way accessibilityIds are being assigned .
content-deschas an extra comma and space in each element, described here: #1112 (comment).The approach in this PR is to proxy calls to the driver, and selectively append the necessary characters (
,) to the call for any functions that need it. Additionally, whereaccessibilityIdXPathAttribis tested for equality, an accessibilityIdSuffix is added to the appropriate ids. The suffix is not required whenaccessibilityIdXPathAttribis tested viacontains, as the lack of the suffix will not affect the match.To test:
yarn test:e2e:android:local