Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Navigation Down in InnerBlocks #1379

Merged
merged 90 commits into from
Dec 11, 2019
Merged

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Sep 24, 2019

Fixes #1314

Please also refer to:
Merge it first gutenberg-mobile PR Add FloatingToolbar component and Feat: Navigation Upward in InnerBlocks
Related gutenberg PR
Related gutenberg-mobile issue

It presents:
Ability to select all parents in cascade way (according to the way how selecting in groups works on web version)

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jbinda jbinda changed the title Callstack/navigate down Feat: Navigation Down in InnerBlocks Sep 24, 2019
@jbinda jbinda requested a review from pinarol September 25, 2019 11:44
@pinarol pinarol added InnerBlocks [Status] Needs Design Review Needs design review or sign-off before shipping labels Sep 25, 2019
@pinarol
Copy link
Contributor

pinarol commented Sep 25, 2019

@jbinda Just curious how is it acting when we have paragraph & heading blocks down in the hierarchy and directly tap on them?

@pinarol
Copy link
Contributor

pinarol commented Sep 25, 2019

@iamthomasbishop this needs a design review, could you be able to take a look at the screen capture here WordPress/gutenberg#17547

@iamthomasbishop
Copy link
Contributor

It’s really great to see the hierarchy navigation in practice, great work so far. I have a few requests, some of which are relevant to other in-progress PRs.

  • Padding’s/margins jumping around a bit make navigating the hierarchy a bit clunky/jumpy. More on that here
  • The dotted border style (on child blocks) is a bit stronger than the proposed style. Let’s dim the color to match the prototype
  • Another thing I’ve already mentioned but worth noting again – it would be beneficial to show the icon of the selected block on the quick toolbar. This would add clarity to what is selected.

I’ll take another look tomorrow, but these are the things that jumped out at me first.

@jbinda
Copy link
Contributor Author

jbinda commented Sep 26, 2019

@pinarol paragraph and heading block gets immediately selected after click whatever level it's is.

I know why but didn't figured out the solution yet. I described it more here (#1314) but in few words the RichText editor takes the focus and I need to lock it somehow (take advantages of modify callback on JS side does't work because the text carret still show up. I assume it is something inside the Aztec native code that catch and handle click/focus). Take a look at below demo:

heading

Do you know any prop that can lock the Aztec editor ?

@pinarol
Copy link
Contributor

pinarol commented Sep 26, 2019

Do you know any prop that can lock the Aztec editor ?

I don't think we have such a thing. Did you have chance to look into web implementation? We might be able to get inspiration from there.

I think we should look for something generic that can be applicable to all blocks, like for example putting a transparent view on block.native.js level to prevent taps and removing it when the block is really focused. Not %100 sure how well it'd work but just an idea.

@jbinda jbinda mentioned this pull request Dec 9, 2019
1 task
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@lukewalczak lukewalczak merged commit cc5b1b4 into develop Dec 11, 2019
@lukewalczak lukewalczak deleted the callstack/navigate-down branch December 11, 2019 09:48
@pinarol pinarol mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InnerBlocks [Status] Needs Design Review Needs design review or sign-off before shipping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inner Blocks - Navigating Down in the hierarchy
5 participants