-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Navigation Down in InnerBlocks #1379
Conversation
@jbinda Just curious how is it acting when we have paragraph & heading blocks down in the hierarchy and directly tap on them? |
@iamthomasbishop this needs a design review, could you be able to take a look at the screen capture here WordPress/gutenberg#17547 |
It’s really great to see the hierarchy navigation in practice, great work so far. I have a few requests, some of which are relevant to other in-progress PRs.
I’ll take another look tomorrow, but these are the things that jumped out at me first. |
@pinarol paragraph and heading block gets immediately selected after click whatever level it's is. I know why but didn't figured out the solution yet. I described it more here (#1314) but in few words the RichText editor takes the focus and I need to lock it somehow (take advantages of modify callback on JS side does't work because the text carret still show up. I assume it is something inside the Aztec native code that catch and handle click/focus). Take a look at below demo: Do you know any prop that can lock the Aztec editor ? |
I don't think we have such a thing. Did you have chance to look into web implementation? We might be able to get inspiration from there. I think we should look for something generic that can be applicable to all blocks, like for example putting a transparent view on block.native.js level to prevent taps and removing it when the block is really focused. Not %100 sure how well it'd work but just an idea. |
…/gutenberg-mobile into callstack/navigate-down
…llstack/navigate-down
…/gutenberg-mobile into callstack/navigate-down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Fixes #1314
Please also refer to:
Merge it first gutenberg-mobile PR Add FloatingToolbar component and Feat: Navigation Upward in InnerBlocks
Related gutenberg PR
Related gutenberg-mobile issue
It presents:
Ability to select all parents in cascade way (according to the way how selecting in groups works on web version)
Update release notes: