[FIX] Floating toolbar #1409
Closed
[FIX] Floating toolbar #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
pinarol
reviewed
Oct 4, 2019
|
Closing for now. It will be open when work over the fix resumes. |
|
Closing for now since it is not working in all cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This is a phase 2 of WordPress/gutenberg#17399
In this PR I fixed the floating toolbar for the first element in a group to be rendered above the block and be clickable.
Gutenberg PR - WordPress/gutenberg#17769
To test:
Check if each of floating toolbar in a group block is clickable and rendered in the correct place
Update release notes:
RELEASE-NOTES.txt.