Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct displaying photo during upload #1758

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Correct displaying photo during upload #1758

merged 2 commits into from
Jan 9, 2020

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jan 8, 2020 •
edited
Loading

Fixes an issue with the wrongly displayed photo during upload. Check details within a gutenberg PR WordPress/gutenberg#19502.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak added this to the 1.20 milestone Jan 8, 2020
@lukewalczak lukewalczak self-assigned this Jan 8, 2020
@pinarol pinarol requested a review from geriux January 8, 2020 09:53
geriux
geriux approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by WordPress/gutenberg#19502 (review)

@lukewalczak lukewalczak merged commit 5a3cbc7 into release/1.20.0 Jan 9, 2020
@dcalhoun dcalhoun deleted the fix-media-text-upload branch August 28, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@lukewalczak lukewalczak

Labels
bugfix
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @geriux