Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Avoid focused unit test #189

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

youknowriad
Copy link
Contributor

This was causing an error in a Gutenberg PR WordPress/gutenberg#10952 but I wonder why it didn't fail in this repository before.

@youknowriad youknowriad self-assigned this Oct 24, 2018
@youknowriad youknowriad requested a review from hypest October 24, 2018 11:03
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, the .only() call was only in for debugging purposes but slipped through and got merged :( Sorry for the trouble @youknowriad .

Thanks for the PR!

@youknowriad youknowriad merged commit c90c364 into master Oct 24, 2018
@youknowriad youknowriad deleted the fix/avoid-focused-test branch October 24, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants