Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust media-text attributes to default stacked on mobile to true #2712

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Oct 12, 2020

Fixes WordPress/gutenberg#26039

Related PR
gutenberg WordPress/gutenberg#26041

Description

This aligns the deprecated baseAttributes value for isStackedOnMobile to default to false matching the default value for the updated settings.

How has this been tested?

  1. In the demo app set the initial HTML content to:
export default `
<!-- wp:media-text {"align":"full","mediaId":696,"mediaType":"image","imageFill":true} -->
<div class="wp-block-media-text alignfull is-stacked-on-mobile is-image-fill"><figure class="wp-block-media-text__media" style="background-image:url('https://a8ctm1.files.wordpress.com/2020/01/dane-deaner-lgjoc2cmff4-unsplash.jpg?w=683');background-position:50% 50%;"><img src="https://a8ctm1.files.wordpress.com/2020/01/dane-deaner-lgjoc2cmff4-unsplash.jpg?w=683" alt="" class="wp-image-696" /></figure>
<div class="wp-block-media-text__content">
<!-- wp:paragraph {"className":"has-large-font-size"} -->
<p class="has-large-font-size"></p>
<!-- /wp:paragraph -->
</div></div>
<!-- /wp:media-text -->
  1. Run the demo app
  2. Expect the Media-text block to be stacked
Before After

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 13, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@enejb
Copy link
Contributor

enejb commented Oct 16, 2020

It needs a rebase but other then that I think this is ready to :shipit:

Copy link
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@chipsnyder chipsnyder merged commit e7deb98 into develop Oct 16, 2020
@chipsnyder chipsnyder deleted the issue/26039-mediaTextImport branch October 16, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants