Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iOS minimum deployment target to iOS 13.0 #2876

Merged
merged 8 commits into from
Mar 30, 2021
Merged

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Dec 8, 2020

Bump minimum deployment target to iOS 13.0

To test: See Gutenberg PR WordPress/gutenberg#27577
WPiOS PR: wordpress-mobile/WordPress-iOS#16171

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 8, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun changed the title Bump iOS deployment target to iOS 13.0 Bump iOS minimum deployment target to iOS 13.0 Dec 8, 2020
@hypest
Copy link
Contributor

hypest commented Jan 22, 2021

👋 Ceyhun, do we need this landed or perhaps it's fine to close?

@ceyhun
Copy link
Contributor Author

ceyhun commented Jan 25, 2021

👋 Ceyhun, do we need this landed or perhaps it's fine to close?

@hypest maybe after wordpress-mobile/WordPress-iOS#15583 is merged we can come back to this and delete some native code (from the bridge or forked 3rd party dependencies) that only run on < iOS 13 while bumping the min. deployment target.

@ceyhun ceyhun requested a review from guarani March 26, 2021 15:15
@ceyhun ceyhun added this to the 1.50.0 (17.1) milestone Mar 26, 2021
@ceyhun ceyhun marked this pull request as ready for review March 26, 2021 15:16
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ceyhun ceyhun merged commit 708d42f into develop Mar 30, 2021
@ceyhun ceyhun deleted the try/min-ios-13 branch March 30, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants