Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Set as Featured Image" Button to Image Block (Android Only) #3116

Merged
merged 30 commits into from
Jun 3, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Feb 8, 2021

Partial fix for: #1011

gutenberg: WordPress/gutenberg#31705
WordPress-Android: wordpress-mobile/WordPress-Android#14503

Internal P2 detailing progress: p9ugOq-1D7-p2

This PR adds a Set as Featured button to the image block's settings, with the purpose being to make it simpler for users to set a featured image within the post's editor. Users will also be able to Remove as Featured directly from the block's settings.

Note: This PR introduces the Set as Featured button to Android devices only, support for iOS will follow in future iterations, too.

To test: Please refer to the Gutenberg PR as the central place for steps to tests and screenshots.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Updating gutenberg reference to include most recent commits.
@SiobhyB SiobhyB force-pushed the update/image-block-with-featured-image-setting branch from a0806df to 6f0ab50 Compare May 11, 2021 19:27
@SiobhyB SiobhyB changed the title Add a "Set as Featured Image" Button to Image Blocks Add a "Set as Featured Image" Button to Image Block (Android Only) May 12, 2021
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @SiobhyB ! Only thing needed is get the Gutenberg PR merged and this can then be updated and merged when CI green!

@SiobhyB SiobhyB merged commit b316b2b into develop Jun 3, 2021
@SiobhyB SiobhyB deleted the update/image-block-with-featured-image-setting branch June 3, 2021 14:01
@antonis antonis mentioned this pull request Jun 11, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants