-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "Set as Featured Image" Button to Image Block (Android Only) #3116
Merged
SiobhyB
merged 30 commits into
develop
from
update/image-block-with-featured-image-setting
Jun 3, 2021
Merged
Add a "Set as Featured Image" Button to Image Block (Android Only) #3116
SiobhyB
merged 30 commits into
develop
from
update/image-block-with-featured-image-setting
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
3 tasks
7 tasks
3 tasks
6 tasks
SiobhyB
force-pushed
the
update/image-block-with-featured-image-setting
branch
2 times, most recently
from
May 11, 2021 19:24
7a6e7ce
to
a0806df
Compare
Updating gutenberg reference to include most recent commits.
SiobhyB
force-pushed
the
update/image-block-with-featured-image-setting
branch
from
May 11, 2021 19:27
a0806df
to
6f0ab50
Compare
SiobhyB
changed the title
Add a "Set as Featured Image" Button to Image Blocks
Add a "Set as Featured Image" Button to Image Block (Android Only)
May 12, 2021
hypest
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @SiobhyB ! Only thing needed is get the Gutenberg PR merged and this can then be updated and merged when CI green!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for: #1011
gutenberg
: WordPress/gutenberg#31705WordPress-Android
: wordpress-mobile/WordPress-Android#14503Internal P2 detailing progress: p9ugOq-1D7-p2
This PR adds a Set as Featured button to the image block's settings, with the purpose being to make it simpler for users to set a featured image within the post's editor. Users will also be able to Remove as Featured directly from the block's settings.
Note: This PR introduces the Set as Featured button to Android devices only, support for iOS will follow in future iterations, too.
To test: Please refer to the Gutenberg PR as the central place for steps to tests and screenshots.
PR submission checklist: