Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more block styling #342

Merged
merged 10 commits into from
Dec 11, 2018
Merged

Update more block styling #342

merged 10 commits into from
Dec 11, 2018

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Dec 10, 2018 •
edited
Loading

Fixes #318 . This PR includes changes for updating styling of more block as below.

screen shot 2018-12-10 at 20 51 31

Code changes are in the child PR.

To Test

  • Open the example app and add a More block
  • Verify "Read more" text has continuous lines around
  • Verify that you can modify "Read More" text and you can enter long text with multiple lines

@pinarol pinarol added this to the Alpha milestone Dec 10, 2018
@pinarol pinarol self-assigned this Dec 10, 2018
@pinarol pinarol mentioned this pull request Dec 10, 2018
Merged
4 tasks
@pinarol pinarol requested a review from hypest December 10, 2018 19:06
hypest
hypest approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've 👍'd the Gutenberg side PR @pinarol, feel free to update to the new Gutenberg hash after that get's merged. Also, feel free to squash all the commits since this PR is essentially just an update of the ref.

@pinarol pinarol merged commit 652b99f into master Dec 11, 2018
@pinarol pinarol deleted the update/more-block-styling branch December 11, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@pinarol pinarol

Labels
None yet
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @hypest