[RNMobile] Parent PR: Add Setting to Set/Remove a Featured Image Directly from Image Block (iOS Only) #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SiobhyB
changed the title
This was referenced May 3, 2021
SiobhyB
changed the title
added 3 commits
May 3, 2021 12:57
SiobhyB
changed the title
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…-featured-badge-ios
…-mobile/gutenberg-mobile into add-featured-badge-ios
…-mobile/gutenberg-mobile into add-featured-badge-ios
[RNMobile] Add Featured Banner to Image Block (iOS Only)
…tton-ios [RNMobile] Add "Set as Featured Image" Button to Image Block (iOS Only)
SiobhyB
force-pushed
the
add/featured-functionality-to-image-block-ios
branch
from
8ba826a
to
c32c06c
Compare
illusaen
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the iOS side of the following issue: #1011
gutenberg: WordPress/gutenberg#31345WordPress-iOS: wordpress-mobile/WordPress-iOS#16427Description
Introduces an option to set/remove an image as featured from the image block's settings, with a "featured" banner to denote when an image is already featured. The end goal is to make it easier for users to both identify and set/remove featured images directly from the post editor.
This PR builds on the work done in WordPress/gutenberg#30806 and WordPress/gutenberg#28854 to introduce this functionality to Android. For iOS, the work has been split up into the following PRs:
Featuredbanner over any image block containing a post's featured imageSet/Remove as Featuredoption in the image block's settings- Once the PR has been merged it will be updated with a ✅
How has this been tested? Screenshots? Types of changes?
Please refer to the first PR in each row (the Gutenberg PR) for test cases, screenshots, and further details of the types of changes involved.
PR submission checklist: