Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.58.0 #3746

Merged
merged 86 commits into from
Jul 22, 2021
Merged

Release 1.58.0 #3746

merged 86 commits into from
Jul 22, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jul 22, 2021

Release for Gutenberg Mobile 1.58.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 22, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB requested a review from fluiddot July 22, 2021 10:36
@SiobhyB SiobhyB marked this pull request as ready for review July 22, 2021 10:36
@fluiddot
Copy link
Contributor

After checking the commits list, I see that there are some PRs that weren't assigned to the 1.58.0 milestone and either mentioned in the release notes but they're included in this release:

I think we should include them in the PR description, as well as assign them to the milestone. I'd also ask authors regarding whether to include those changes in the release notes, wdyt?

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 22, 2021

@fluiddot, thank you for spotting those!

I see there were changes to the RELEASE-NOTES in #3724 but they weren't showing up locally for me for some reason. 🤔 I'll add them.

I'm not seeing changes to the RELEASE-NOTES for the other three, but all the authors checked the I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary. item off, so I'm assuming this was intentional. The changes themselves aren't things users will necessarily notice:

I'd be okay with leaving those three out of the release notes and adding them to this PR description? WDYT? (Also noting that two out of the three PR authors are AFK.)

@fluiddot
Copy link
Contributor

@fluiddot, thank you for spotting those!

I see there were changes to the RELEASE-NOTES in #3724 but they weren't showing up locally for me for some reason. 🤔 I'll add them.

Oh sorry, I've just realized that #3724 was released on version 1.57.1 not this one, that's why it wasn't in the unreleased section.

I'm not seeing changes to the RELEASE-NOTES for the other three, but all the authors checked the I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary. item off, so I'm assuming this was intentional. The changes themselves aren't things users will necessarily notice:

I'd be okay with leaving those three out of the release notes and adding them to this PR description? WDYT? (Also noting that two out of the three PR authors are AFK.)

Good point, in that case, I'd only include them in the PR description and milestone, thanks 🙇 !

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

I did a quick test on both platforms and worked fine:

@SiobhyB SiobhyB merged commit 0028fdc into trunk Jul 22, 2021
@SiobhyB SiobhyB deleted the release/1.58.0 branch July 22, 2021 18:14
@fluiddot fluiddot added this to the 1.58.0 (17.9) milestone Jul 23, 2021
@fluiddot
Copy link
Contributor

fluiddot commented Jul 27, 2021

🟢 Writing Flow Test Cases (iOS)

Tested with WPiOS 17.9.0.0 build on iPhone 11 (iOS 14.2).

General

  • TC001 - Block insertion
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor

fluiddot commented Jul 27, 2021

🟢 Unsupported Block Test Cases (iOS)

Tested with WPiOS 17.9.0.0 build on iPhone 11 (iOS 14.2).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • 🟡 [skipped due to a known issue] TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor

fluiddot commented Jul 27, 2021

🟢 Test the new changes (iOS)

  • New Block: Embed block: Enable embed block Enable embed block #3727
  • [not required as it only applies to Android] Fix invisible Android activity indicator: Fix invisible Android activity indicator
  • [not required as it's behind the DEV flag] Editor Onboarding: "The Basics" help section - Topics List UI: Editor Onboarding: "The Basics" help section - Topics List UI
  • [not required as it doesn't include user-facing changes] Update dependencies from forks to use release tags: Update dependencies from forks to use release tags

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 27, 2021

🟢 Writing Flow Test Cases (Android)

Tested with WPAndroid 17.9.0.0 build on Pixel 5 (Android 11).

General

  • TC001 - Block insertion
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 27, 2021

🟢 Unsupported Block Test Cases (Android)

Tested with WPAndroid 17.9.0.0 build on Pixel 5 (Android 11).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 27, 2021

🟢 Test the new changes (Android)

Tested with WPAndroid 17.9.0.0 build on Pixel 5 (Android 11).

  • New Block: Embed block: Enable embed block Enable embed block #3727
  • Fix invisible Android activity indicator: Fix invisible Android activity indicator Fix invisible Android activity indicator #3716
  • [not required as it's behind the DEV flag] Editor Onboarding: "The Basics" help section - Topics List UI: Editor Onboarding: "The Basics" help section - Topics List UI
  • [not required as it doesn't include user-facing changes] Update dependencies from forks to use release tags: Update dependencies from forks to use release tags

@geriux
Copy link
Contributor

geriux commented Jul 27, 2021

⚪️ Test suite 1 (iOS)

Tested with WPiOS 17.9.0.0 on iPhone 12 Pro (14.6)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • ⚠️ Columns - Columns percentage mechanism - column's slider input - TC020
    Note: encounter an issue that is already reported using the , character.
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@chipsnyder
Copy link
Contributor

chipsnyder commented Jul 27, 2021

🟢 Test suite 2 (Android)

Tested with WPAndroid 17.9.0.0 on Pixel 3a (11.0)


DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@fluiddot fluiddot restored the release/1.58.0 branch July 29, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants