Release 1.59.0

.buildkite/pipeline.yml

@@ -0,0 +1,45 @@
+x-common-params:
+  &publish-android-artifacts-docker-container
+  docker#v3.8.0:
+    image: "public.ecr.aws/automattic/android-build-image:v1.1.0"
+    propagate-environment: true
+    environment:
+      # DO NOT MANUALLY SET THESE VALUES!
+      # They are passed from the Buildkite agent to the Docker container
+      - "AWS_ACCESS_KEY"
+      - "AWS_SECRET_KEY"
+
+steps:
+  - label: "Bundle Android"
+    key: "bundle-android"
+    plugins:
+      - docker#v3.8.0:
+          image: "public.ecr.aws/automattic/gb-mobile-image:latest"
+          environment:
+            - "CI=true"
+    command: |
+        source /root/.bashrc
+
+        pushd gutenberg && nvm install && nvm use && popd
+        npm ci --unsafe-perm --prefer-offline --no-audit --no-progress
+
+        npm run prebundle:js
+        npm run bundle:android
+
+        buildkite-agent artifact upload bundle/android/App.js
+
+  - label: "Build Android RN Aztec & Publish to S3"
+    key: "publish-react-native-aztec-android"
+    plugins:
+      - *publish-android-artifacts-docker-container
+    command: |
+        .buildkite/publish-react-native-aztec-android-artifacts.sh
+
+  - label: "Build Android RN Bridge & Publish to S3"
+    depends_on:
+      - "bundle-android"
+      - "publish-react-native-aztec-android"
+    plugins:
+      - *publish-android-artifacts-docker-container
+    command: |
+        .buildkite/publish-react-native-bridge-android-artifacts.sh

.buildkite/publish-react-native-aztec-android-artifacts.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+set -euo pipefail
+
+# Publish react-native-aztec
+cd ./gutenberg/packages/react-native-aztec/android
+./gradlew -PwillPublishReactNativeAztecBinary=true :prepareToPublishToS3 `prepare_to_publish_to_s3_params` :publish
+
+# Add meta-data for the published version so we can use it while publishing `react-native-bridge` library
+cat ./build/published-version.txt | buildkite-agent meta-data set "PUBLISHED_REACT_NATIVE_AZTEC_ANDROID_VERSION"

.buildkite/publish-react-native-bridge-android-artifacts.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+set -euo pipefail
+
+# Retrieve data from previous steps
+PUBLISHED_AZTEC_VERSION=`buildkite-agent meta-data get "PUBLISHED_REACT_NATIVE_AZTEC_ANDROID_VERSION"`
+buildkite-agent artifact download bundle/android/App.js .
+
+# Move app bundled JS file to the correct location
+mkdir -p gutenberg/packages/react-native-bridge/android/react-native-bridge/build/assets
+cp ./bundle/android/App.js ./gutenberg/packages/react-native-bridge/android/react-native-bridge/build/assets/index.android.bundle
+
+# Publish react-native-bridge
+cd ./gutenberg/packages/react-native-bridge/android
+./gradlew -PwillPublishReactNativeBridgeBinary=true -PreactNativeAztecVersion="$PUBLISHED_AZTEC_VERSION" :react-native-bridge:prepareToPublishToS3 `prepare_to_publish_to_s3_params` :react-native-bridge:publish

.circleci/config.yml

@@ -12,7 +12,9 @@ commands:
             - npm-i18n-v4-cache-v{{ .Environment.CACHE_TRIGGER_VERSION }}-job-{{ .Environment.CIRCLE_JOB }}-{{ checksum "package-lock.json" }}
       - run:
           name: NPM Install
-          command: npm ci --prefer-offline --no-audit
+          command: |
+            echo "Node version: $(node --version)"
+            npm ci --prefer-offline --no-audit
       - save_cache:
           name: Save NPM Cache
           key: npm-i18n-v4-cache-v{{ .Environment.CACHE_TRIGGER_VERSION }}-job-{{ .Environment.CIRCLE_JOB }}-{{ checksum "package-lock.json" }}
@@ -27,7 +29,9 @@ commands:
             - npm-i18n-v4-cache-v{{ .Environment.CACHE_TRIGGER_VERSION }}-job-{{ .Environment.CIRCLE_JOB }}-{{ checksum "gutenberg/package-lock.json" }}
       - run:
           name: NPM Install Full
-          command: npm install --no-audit
+          command: |
+            echo "Node version: $(node --version)"
+            npm install --no-audit
       - save_cache:
           name: Save NPM Cache
           key: npm-i18n-v4-cache-v{{ .Environment.CACHE_TRIGGER_VERSION }}-job-{{ .Environment.CIRCLE_JOB }}-{{ checksum "gutenberg/package-lock.json" }}
@@ -106,6 +110,26 @@ commands:
         - run:
             name: Create reports directory
             command: mkdir reports && mkdir reports/test-results
+  install-node-version:
+    steps:
+      - run:
+          name: Install newer nvm
+          command: |
+            curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash
+            if [ -z "${NVM_DIR}" ] ; then
+              echo 'Appending nvm source string to BASH_ENV'
+              echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV
+              echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
+            fi
+      - run:
+          name: Install node version specified in Gutenberg using nvm
+          command: |
+            cd gutenberg
+            nvm install
+            # Set the installed version as the default one
+            nvm alias default $(nvm current)
+            # Enforce to use the default version in the rest of workflow
+            echo 'nvm use default' >> $BASH_ENV
 
 parameters:
   android-docker-image:
@@ -134,14 +158,7 @@ jobs:
     steps:
       - checkout-shallow
       - checkout-submodules
-      - run:
-          name: Install newer nvm
-          command: curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.37.2/install.sh | bash
-      - run:
-          name: Install newer node using nvm
-          command: |
-            cd gutenberg
-            nvm install
+      - install-node-version
       - when:
           condition: <<parameters.check-correctness>>
           steps:
@@ -178,6 +195,7 @@ jobs:
     steps:
       - checkout-shallow
       - checkout-submodules
+      - install-node-version
       - run: node -v
       - npm-install
       - run: npm run test:e2e:bundle:android
@@ -226,6 +244,7 @@ jobs:
     steps:
       - checkout-shallow
       - checkout-submodules
+      - install-node-version
       - npm-install
       - run:
           name: Run Android native unit tests
@@ -244,6 +263,7 @@ jobs:
     steps:
     - checkout-shallow
     - checkout-submodules
+    - install-node-version
     - npm-install
     - add-jest-reporter-dir
     - run:
@@ -314,101 +334,6 @@ jobs:
                 include_job_number_field: false
                 include_project_field: false
                 failure_message: ':red_circle: Scheduled tests failed on iOS device!'
-  android-build-and-publish-react-native-bridge:
-    # This job builds the JS bunle required by the Android version of the
-    # react-native-bridge package, builds the AAR for that package, and uploads
-    # it to S3.
-    #
-    # Running on a Ubuntu machine to have more memory compared to the Docker +
-    # Node or Docker + Android images that CircleCI offers (circleci/node)
-    #
-    # Also running all in one job so that we can bail out early under cetrain
-    # conditions and save CI cycles.
-    #
-    # See: https://github.com/wordpress-mobile/gutenberg-mobile/pull/3038#issuecomment-765334675
-    machine:
-      image: << pipeline.parameters.linux-machine-image >>
-    steps:
-      - run:
-          name: Evaluate whether to run
-          command: |
-            # This is a partial duplication of the logic to compute the version
-            # to use for the AAR from below. It's useful to have it here
-            # because there are conditions under which we shouldn't run the job
-            # that can't be captured in a CircleCI filter.
-            #
-            # Exiting here saves a non-trivial amount of CI time because of how
-            # heavy the repo is to checkout (it takes at least 1 minute) and
-            # how time consuming running `npm ci` is.
-            if [[ -z ${CIRCLE_TAG+x} ]]; then
-              if [[ -n "$CIRCLE_PULL_REQUEST" ]]; then
-                echo "Build initiated from a branch with a pull request: proceeding..."
-              elif [[ $CIRCLE_BRANCH == "develop" ]]; then
-                echo "Build initiated on $CIRCLE_BRANCH: proceeding..."
-              else
-                # We end up here on the first push of a new branch, when there
-                # isn't a PR open for it yet.
-                echo "Build initiated from a feature branch with no pull request: aborting."
-                circleci-agent step halt
-              fi
-            else
-              echo "Build initiated from a tag: proceeding..."
-            fi
-      - checkout-shallow
-      - checkout-submodules
-      - run:
-          # Setting up Android before fetching the Node dependencies because
-          # this step is faster, so if it fails we'll learn about it sooner and
-          # avoid wasting cycles.
-          name: Setup Android Tooling
-          command: .circleci/setup-android-on-ubuntu.sh
-      - npm-install
-      - run:
-          name: Build JavaScript Bundle
-          command: |
-            npm run prebundle:js
-            npm run bundle:android
-          # The job can take a long time, so let's bump the no_output_timeout
-          # to more than the default 10m
-          no_output_timeout: 20m
-      - run:
-          name: Build React Native Bridge & Upload to S3
-          environment:
-            # This value is set in the setup script, but I'm not sure whether
-            # it's available after executing it
-            ANDROID_SDK_ROOT: /usr/lib/android-sdk
-          command: |
-            # We publish from PRs as well as the main branch and tags to help
-            # developers to iterate faster.
-            #
-            # If we're not on a PR but a merge commit on the develop branch the
-            # version will be the "develop-" followed by the commit SHA1.
-            #
-            # On a tag, the version should be the tag value.
-            #
-            # If we're on a different branch that has no open PR, we should
-            # not build and exit early instead.
-            if [[ -z "${CIRCLE_TAG+x}" ]]; then
-              if [[ -n "$CIRCLE_PULL_REQUEST" ]]; then
-                PR_NUMBER=$(basename $CIRCLE_PULL_REQUEST)
-                # CIRCLE_SHA1 should always be available.
-                VERSION="$PR_NUMBER-$CIRCLE_SHA1"
-              elif [[ $CIRCLE_BRANCH == "develop" ]]; then
-                VERSION="$CIRCLE_BRANCH-$CIRCLE_SHA1"
-              else
-                # This happens on the first push of a new branch, when there
-                # isn't a PR open for it yet.
-                echo "Running on a feature branch with no open PR."
-                echo "The checks previous to this step should not have let this happen."
-                exit 1
-              fi
-            else
-              VERSION=$CIRCLE_TAG
-            fi
-
-            cd gutenberg/packages/react-native-bridge/android
-
-            ./publish-aztec-and-bridge.sh $VERSION
 
 workflows:
   gutenberg-mobile:
@@ -457,15 +382,6 @@ workflows:
           filters:
             branches:
               only: /^dependabot/submodules/.*/
-      - android-build-and-publish-react-native-bridge:
-          name: Build Android RN Bridge & Publish to S3
-          filters:
-            branches:
-              # Don't run on trunk, otherwise, run on every other branch
-              ignore: trunk
-            tags:
-              # Run for every tag
-              only: /.*/
 
   ui-tests-full-scheduled:
     jobs:

RELEASE-NOTES.txt

@@ -1,5 +1,7 @@
-Unreleased
+1.59.0
 ------
+* [*] [Android] Fix UBE's inaccessible "more" toolbar item. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3771]
+* [*] Image block: Add a "featured" banner and ability to set or remove an image as featured. (iOS only) [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3449]
 
 1.58.2
 ------