-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Text Entry Errors in Alt Text Settings #3818
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
ea620e4
to
9f4dcca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why the App.js
file shows that 2,999 lines have been removed 🤔 , could we take a look at this before merging?
Apart from that the changes have been tested and are approved via WordPress/gutenberg#33975 (review).
bb5659a
to
4570c0d
Compare
😱 Thank you for flagging, I believe that was a result of my not updating the bundle after I stopped updating the installable builds for this PR. There must have been some mix-up between that and merge conflicts somewhere down the line. As changes to the bundle aren't required for this PR, I rewrote the commit history and updated it to only have changes to the Gutenberg reference. Let me know if that looks okay to you! 🙇♀️ |
Good idea, since the bundle is not required better to revert those changes 👍 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#33975 (review).
NOTE: The Gutenberg ref should point to the merge commit in Gutenberg's trunk
branch before merging this PR.
Fixes:
Gutenberg:
Description
Please refer to the Gutenberg PR as the central, most up-to-date place for a description and testing steps.
PR submission checklist: