Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of useInnerBlocksProps API #4196

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Update usage of useInnerBlocksProps API #4196

merged 3 commits into from
Nov 3, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Nov 2, 2021 •
edited
Loading

Updates the Tiled Gallery feature branch to fix an error caused by the useInnerBlocksProps API changing name.

Related:

To test

  1. Run the packager by executing npm run start:reset in one terminal window
  2. Run the demo app for iOS in another terminal window, e.g npm run core ios
  3. Verify the block can be inserted via the block inserter, the block inserter search, and the slash inserter
  4. Run the demo app for Android, npm run core android
  5. Repeat step 3

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani mentioned this pull request Nov 2, 2021
Merged
@guarani guarani changed the title Fix/tiled gallery inner block api Update usage of useInnerBlocksProps API Nov 2, 2021
@guarani guarani changed the base branch from develop to add/tiled-gallery-block November 2, 2021 18:30
@guarani guarani marked this pull request as ready for review November 2, 2021 19:04
SiobhyB
SiobhyB approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Automattic/jetpack#21625 (review)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 3, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani merged commit 6d145bc into add/tiled-gallery-block Nov 3, 2021
@guarani guarani deleted the fix/tiled-gallery-inner-block-api branch November 3, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

@illusaen illusaen Awaiting requested review from illusaen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guarani @SiobhyB